Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding NRI flag #1956

Merged
merged 1 commit into from
Feb 3, 2025
Merged

adding NRI flag #1956

merged 1 commit into from
Feb 3, 2025

Conversation

daemon1024
Copy link
Member

@daemon1024 daemon1024 commented Jan 28, 2025

Purpose of PR?:
Adding NRI capability under the flag, removing being available as by-default.

workflow:

  • snitch detects NRI availablity
  • based on KubearmorConfig, operator decides whether to add NRI annotaions(volume mounts) or not
  • based on these annotaitons kubearmor will decide who will monitor container events

Fixes #

Does this PR introduce a breaking change?

If the changes in this PR are manually verified, list down the scenarios covered::

Additional information for reviewer? :
Mention if this PR is part of any design or a continuation of previous PRs

Checklist:

  • Bug fix. Fixes #
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • PR Title follows the convention of <type>(<scope>): <subject>
  • Commit has unit tests
  • Commit has integration tests

@Prateeknandle Prateeknandle force-pushed the nri-flag branch 4 times, most recently from 7c4dd32 to 8e95717 Compare January 29, 2025 12:31
Copy link
Collaborator

@rksharma95 rksharma95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just few comments, rest LGTM

pkg/KubeArmorOperator/common/defaults.go Outdated Show resolved Hide resolved
pkg/KubeArmorOperator/internal/controller/cluster.go Outdated Show resolved Hide resolved
@Prateeknandle Prateeknandle force-pushed the nri-flag branch 6 times, most recently from 3930c69 to b71c3c6 Compare January 31, 2025 18:57
Aryan-sharma11
Aryan-sharma11 previously approved these changes Feb 3, 2025
Signed-off-by: Prateek <[email protected]>
@rksharma95 rksharma95 merged commit a772a15 into kubearmor:main Feb 3, 2025
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants