Refactor kubedl_job_status implementation to log status changes for each job and add metric: kubedl_job_finished_time #313
+33
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #313 +/- ##
==========================================
- Coverage 30.92% 30.88% -0.04%
==========================================
Files 108 108
Lines 7024 7033 +9
==========================================
Hits 2172 2172
- Misses 4556 4565 +9
Partials 296 296
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
…ach job and add metric: kubedl_job_finished_time Signed-off-by: paradox <[email protected]>
Signed-off-by: paradox <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ach job and add metric: kubedl_job_finished_time
Ⅰ. Describe what this PR does
1、Refactor kubedl_job_status implementation to log status changes for each job
2、Add metric: kubedl_job_finished_time
II. Does this pull request fix one issue?
fixes #309
III. Special notes for reviewers if any.