Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[bug] SDK Test Failing #11038

Open
DharmitD opened this issue Jul 25, 2024 · 5 comments · May be fixed by #11285
Open

[bug] SDK Test Failing #11038

DharmitD opened this issue Jul 25, 2024 · 5 comments · May be fixed by #11285
Assignees
@DharmitD
Labels
area/testing kind/bug

Comments

@DharmitD
Copy link
Contributor

This SDK test is failing: https://github.com/kubeflow/pipelines/blob/master/sdk/python/kfp/cli/component_test.py#L579


=================================== FAILURES ===================================
_____________ Test.test_dockerfile_can_contain_custom_kfp_package ______________

self = <kfp.cli.component_test.Test testMethod=test_dockerfile_can_contain_custom_kfp_package>

    def test_dockerfile_can_contain_custom_kfp_package(self):
        component = _make_component(
            func_name='train', target_image='custom-image')
        _write_components('components.py', component)
        package_dir = os.path.dirname(os.path.dirname(self.current_dir))
    
        # suppresses large stdout from subprocess that builds kfp package
        with mock.patch.object(
                subprocess,
                'run',
                new=functools.partial(subprocess.run, capture_output=True)):
            result = self.runner.invoke(
                self.cli,
                [
                    'build',
                    str(self._working_dir), f'--kfp-package-path={package_dir}'
                ],
            )
>       self.assertEqual(result.exit_code, 0)
E       AssertionError: 1 != 0

sdk/python/kfp/cli/component_test.py:597: AssertionError
------------------------------ Captured log call -------------------------------
ERROR    root:component.py:122 Failed to find built KFP wheel under /tmp/tmpbrsaqwfx
=============================== warnings summary ===============================

Steps to reproduce

  • run the following command from the repo's root directory: pytest sdk/python/kfp --ignore=sdk/python/kfp/deprecated --cov=kfp

/area testing
@DharmitD DharmitD mentioned this issue Jul 25, 2024
Merged
1 task
@github-actions GitHub Actions
Copy link

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the lifecycle/stale The issue / pull request is stale, any activities remove this label. label Sep 23, 2024
@DharmitD DharmitD linked a pull request Oct 11, 2024 that will close this issue
Open
2 tasks
@github-actions GitHub Actions
Copy link

This issue has been automatically closed because it has not had recent activity. Please comment "/reopen" to reopen it.

@DharmitD
Copy link
Contributor Author

/reopen

@google-oss-prow google-oss-prow bot reopened this Oct 14, 2024
@google-oss-prow Google OSS Prow
Copy link

@DharmitD: Reopened this issue.

In response to this:

/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@github-actions github-actions bot removed the lifecycle/stale The issue / pull request is stale, any activities remove this label. label Oct 15, 2024
DharmitD added a commit to DharmitD/data-science-pipelines-argo that referenced this issue Oct 17, 2024
@DharmitD
Re-enable test_dockerfile_can_contain_custom_kfp_package by removing …
9e4ef1a 
…skip decorator

Removed the  decorator from  that was previously added to bypass the test due to failure (referencing issue kubeflow#11038).

With the recent fixes applied, including upgrading to Python 3.9 and ensuring compatibility with subprocess handling and Click, the test now passes consistently. This commit re-enables the test to ensure proper validation of Dockerfile creation and KFP package builds during containerized component creation.
DharmitD added a commit to DharmitD/data-science-pipelines-argo that referenced this issue Oct 17, 2024
@DharmitD
Re-enable test_dockerfile_can_contain_custom_kfp_package
c42c14d 
Removed the skip unit test decorator that was previously added to bypass the test due to failure (referencing issue kubeflow#11038).

The issue reported in kubeflow#11038 was caused due to the Dockerfile referencing to Python 3.7. With the Python version updated to 3.9, the test now passes consistently.
This commit re-enables the test to ensure proper validation of Dockerfile creation and KFP package.

Signed-off-by: ddalvi <[email protected]>
@DharmitD DharmitD mentioned this issue Oct 17, 2024
Open
2 tasks
DharmitD added a commit to DharmitD/data-science-pipelines-argo that referenced this issue Oct 17, 2024
@DharmitD
Re-enable test_dockerfile_can_contain_custom_kfp_package
b87eee2 
Removed the skip unit test decorator that was previously added to bypass the test due to failure (referencing issue kubeflow#11038).

The issue reported in kubeflow#11038 was caused due to the Dockerfile referencing to Python 3.7. With the Python version updated to 3.9, the test now passes consistently.
This commit re-enables the test to ensure proper validation of Dockerfile creation and KFP package.

Signed-off-by: ddalvi <[email protected]>
DharmitD added a commit to DharmitD/data-science-pipelines-argo that referenced this issue Oct 22, 2024
@DharmitD
Re-enable test_dockerfile_can_contain_custom_kfp_package
c0f0486 
Removed the skip unit test decorator that was previously added to bypass the test due to failure (referencing issue kubeflow#11038).

The issue reported in kubeflow#11038 was caused due to the Dockerfile referencing to Python 3.7. With the Python version updated to 3.9, the test now passes consistently.
This commit re-enables the test to ensure proper validation of Dockerfile creation and KFP package.

Signed-off-by: ddalvi <[email protected]>
@DharmitD
Copy link
Contributor Author

/assign @DharmitD

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@DharmitD DharmitD

Labels
area/testing kind/bug
Projects
None yet
Milestone
No milestone
1 participant
@DharmitD