-
Notifications
You must be signed in to change notification settings - Fork 735
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
KEP-2170: Deploy JobSet in kubeflow-system
namespace
#2388
Merged
google-oss-prow
merged 6 commits into
kubeflow:master
from
andreyvelich:change-v2-manifests
Jan 27, 2025
Merged
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
e99f1ce
KEP-2170: Deploy JobSet in kubeflow-system namespace
andreyvelich de9c1e2
Remove namespace from base
andreyvelich 2d0fa6a
Remove label from namespace
andreyvelich 6021349
Create third-party dir for JobSet
andreyvelich ce42837
Bump JobSet to v0.7.3
andreyvelich c78d980
Drop namespace from JobSet config
andreyvelich File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Create third-party dir for JobSet
Signed-off-by: Andrey Velichkevich <andrey.velichkevich@gmail.com>
- Loading branch information
commit 6021349dc3740d979e7acfe54647f57d1f3b35d2
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
File renamed without changes.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,19 @@ | ||
apiVersion: kustomize.config.k8s.io/v1beta1 | ||
kind: Kustomization | ||
|
||
resources: | ||
- https://github.com/kubernetes-sigs/jobset/releases/download/v0.7.2/manifests.yaml | ||
|
||
# Config for the JobSet manager. | ||
# TODO (andreyvelich): Remove this when this is released: https://github.com/kubernetes-sigs/jobset/issues/720 | ||
configMapGenerator: | ||
- name: jobset-manager-config | ||
files: | ||
- jobset_manager_config.yaml | ||
options: | ||
disableNameSuffixHash: true | ||
|
||
# Add required patches. | ||
patchesStrategicMerge: | ||
- patches/jobset_remove_namespace.yaml # Remove namespace from the JobSet release manifests. | ||
- patches/jobset_config_patch.yaml # Add custom manager config to the JobSet. |
File renamed without changes.
File renamed without changes.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shall we also patch those namespace related configurations outside of the
.metadata
field? Like: https://github.com/kubeflow/training-operator/pull/2382/files#r1914094979It seems that we also need to patch those webhook configurations to ensure
jobset
working correctly:)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I noticed that even without this config, the kustomize correctly patches the JobSet's manifests with:
I think, it works without this configuration since the JobSet manifests includes this service which tells kustomize that namespace in
clientConfig
needs to be patched.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
SGTM!