Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Openstack provider clean-up #691

Open
irozzo-1A opened this issue Feb 21, 2020 · 3 comments
Open

Openstack provider clean-up #691

irozzo-1A opened this issue Feb 21, 2020 · 3 comments
Labels
kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. priority/low Not that important. sig/cluster-management Denotes a PR or issue as being assigned to SIG Cluster Management.

Comments

@irozzo-1A
Copy link
Contributor

irozzo-1A commented Feb 21, 2020

This issue is to do some clean-up in the openstack provider logic, that in some cases is not very clear or optimal. A few examples:

In order to get a network by name or ID we iterate through all networks instead of getting it directly with the proper API call:
https://github.com/kubermatic/machine-controller/blob/master/pkg/cloudprovider/provider/openstack/helper.go#L217

Same applies for security groups:
https://github.com/kubermatic/machine-controller/blob/master/pkg/cloudprovider/provider/openstack/helper.go#L184

The logic we use to get the default subset is a bit obscure: if we have just one subnet in the network provided in input we return it otherwise we obtain the subnets from the API and we return the first if any or we throw an error. If there is a reason behind that, I have some doubts, we should at least comment it properly.
https://github.com/kubermatic/machine-controller/blob/master/pkg/cloudprovider/provider/openstack/helper.go#L416

@kdomanski kdomanski added priority/normal Not that urgent, but is important sig/cluster-management Denotes a PR or issue as being assigned to SIG Cluster Management. labels Mar 5, 2020
@kubermatic-bot
Copy link
Contributor

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@kubermatic-bot kubermatic-bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jun 3, 2020
@kubermatic-bot
Copy link
Contributor

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

/lifecycle rotten

@kubermatic-bot kubermatic-bot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Sep 23, 2020
@xmudrii
Copy link
Member

xmudrii commented Oct 8, 2020

/remove-lifecycle rotten
/kind cleanup

@kubermatic-bot kubermatic-bot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. and removed lifecycle/rotten Denotes an issue or PR that has aged beyond stale. labels Oct 8, 2020
@shaase-ctrl shaase-ctrl added priority/low Not that important. and removed priority/normal Not that urgent, but is important labels Nov 19, 2020
@zreigz zreigz self-assigned this Apr 11, 2022
@zreigz zreigz closed this as completed May 10, 2022
@zreigz zreigz reopened this May 10, 2022
@zreigz zreigz removed their assignment May 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. priority/low Not that important. sig/cluster-management Denotes a PR or issue as being assigned to SIG Cluster Management.
Projects
None yet
Development

No branches or pull requests

6 participants