-
Notifications
You must be signed in to change notification settings - Fork 526
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade to 0.22.2 fails due to use of new major version of client-node. #2014
Comments
I'll try to repro this. I would have thought that the unit tests for this code would have failed though. Do you have a snippet of code that reproduces this? Also, what version of Node are you using? |
It looks like #1969 bumped the openid-client dependency from 5.7.0 to 6.1.3. Looking at the v6.0.0 release notes, that dependency switched to being an ESM module. Since the TypeScript code is transpiled to use |
Similar to what I mentioned in #1975 - it might be worth running the tests against the transpiled code. |
I'm curious what the maintainers would think about reverting #1969 on the v0.x release line, and using this as a reason to move the 1.x release line to ESM. I think that would cause the fewest future headaches. |
@brendandburns I think that would be a very valid breaking change. |
@brendandburns do you have any thoughts on #2014 (comment)? |
I'm ok with that. |
Describe the bug
When upgraded to latest version
0.22.2
of this library getting the following error:This appears to be due to using the new version of
client-node
.** Client Version **
0.22.2
** Server Version **
e.g.
1.19.1
To Reproduce
Steps to reproduce the behavior:
Expected behavior
A clear and concise description of what you expected to happen.
** Example Code**
Code snippet for what you are doing
Environment (please complete the following information):
Additional context
Add any other context about the problem here.
The text was updated successfully, but these errors were encountered: