Controller should be optional

[ktarplee]

According to the CSI spec, the controller is actually optional. I would like a way to run the tests without assuming the controller exists. Only the NodeServer and IdentityServer are present in my OCI plugin.

From the spec

CONTROLLER_SERVICE indicates that the Plugin provides RPCs for
the ControllerService. Plugins SHOULD provide this capability.
In rare cases certain plugins MAY wish to omit the
ControllerService entirely from their implementation, but such
SHOULD NOT be the common case.

I tried adding -ginkgo.focus Node but there are still tests that fail due to calling controller RPCs such as

• Failure [0.002 seconds]
Node Service
/code/oss/csi-test/pkg/sanity/tests.go:44
  NodeStageVolume
  /code/oss/csi-test/pkg/sanity/node.go:424
    should fail when no volume capability is provided [It]
    /code/oss/csi-test/pkg/sanity/node.go:475

    Unexpected error:
        <*status.statusError | 0xc000430c30>: {
            Code: 12,
            Message: "unknown service csi.v1.Controller",
            Details: nil,
            XXX_NoUnkeyedLiteral: {},
            XXX_unrecognized: nil,
            XXX_sizecache: 0,
        }
        rpc error: code = Unimplemented desc = unknown service csi.v1.Controller
    occurred

[pohly]

That's a valid issue. The controller is needed to create volumes that then can be used during the node operations. Another approach for specifying valid volumes will be needed when testing without controller. Patches welcome...

[fejta-bot]

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

[fejta-bot]

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle rotten

[fejta-bot]

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-contributor-experience at kubernetes/community.
/close

[k8s-ci-robot]

@fejta-bot: Closing this issue.

In response to this:

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-contributor-experience at kubernetes/community.
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[cyga]

I would like to re-open this issue. We also have a case when we don't really use controller service.
Also, we don't use grouop controller service.
However, we ended up specifying dummy ones to use this testing library for other functionality we have.

[pohly]

/reopen

[k8s-ci-robot]

@pohly: Reopened this issue.

In response to this:

/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[k8s-triage-robot]

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

• Reopen this issue with /reopen
• Mark this issue as fresh with /remove-lifecycle rotten
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close not-planned

[k8s-ci-robot]

@k8s-triage-robot: Closing this issue, marking it as "Not Planned".

In response to this:

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

• Reopen this issue with /reopen
• Mark this issue as fresh with /remove-lifecycle rotten
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close not-planned

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.