-
Notifications
You must be signed in to change notification settings - Fork 148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ControllerModifyVolume RPC sanity tests #538
Add ControllerModifyVolume RPC sanity tests #538
Conversation
Welcome @AndrewSirenko! |
Hi @AndrewSirenko. Thanks for your PR. I'm waiting for a kubernetes-csi member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/uncc |
/ok-to-test |
34b6775
to
d4cc130
Compare
Can you squash the commits? |
d4cc130
to
4fe8f0b
Compare
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: AndrewSirenko, xing-yang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind feature
What this PR does / why we need it:
Adds sanity tests for the ControllerModifyVolume RPC such that VolumeAttributesClass ModifyVolume enhancement KEP-3751 can be promoted to Beta
Which issue(s) this PR fixes:
N/A
Special notes for your reviewer:
Squashed the commits, but previously we also had:
Active Questions:
Should we enforce empty MutableParameters list as InvalidArgument Err? KEP says don't enforce because field OPTIONAL, csi-spec has no mention, k/k type says required, hostpath-driver does enforce with InvalidArgument on empty.Do not enforceHow to enforce no conflicts between SC and VAC if both are opaque? Loop through parameter lists for duplicated keys? Or leave out test for now.Leave out for now, made issue Test ControllerModifyVolume for "Values specified in mutable_parameters MUST take precedence over the values from parameters" #549.Does this PR introduce a user-facing change?: