Skip to content

Commit

Permalink
Merge pull request #886 from BobyMCbobs/add-configurable-nodeport-for…
Browse files Browse the repository at this point in the history
…-charts

chore: add configurable nodeport
  • Loading branch information
k8s-ci-robot authored Jun 26, 2024
2 parents 854618f + 7057670 commit dd103ce
Show file tree
Hide file tree
Showing 4 changed files with 6 additions and 0 deletions.
2 changes: 2 additions & 0 deletions charts/auditlogger/templates/service.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,8 @@ spec:
- port: 9900
targetPort: http
protocol: TCP
{{- if (and .Values.service.nodePort (eq .Values.service.type "NodePort")) }}
nodePort: {{ .Values.service.nodePort }}{{- end}}
name: http
selector:
{{- include "auditlogger.selectorLabels" . | nindent 4 }}
Expand Down
1 change: 1 addition & 0 deletions charts/auditlogger/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -52,6 +52,7 @@ service:
# "WE disable this for now as we work on vcluster"
# 2023-09-18: Adding this back so this can work on non-vcluster environments, like kind+knative+apisnoop
clusterIP: 10.96.96.96
# nodePort: 30990

resources:
{}
Expand Down
2 changes: 2 additions & 0 deletions charts/snoopdb/templates/service.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,8 @@ spec:
ports:
- port: {{ .Values.service.port }}
targetPort: {{ .Values.service.port }}
{{- if (and .Values.service.nodePort (eq .Values.service.type "NodePort")) }}
nodePort: {{ .Values.service.nodePort }}{{- end}}
protocol: TCP
name: postgres
selector:
Expand Down
1 change: 1 addition & 0 deletions charts/snoopdb/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,7 @@ securityContext:
service:
type: ClusterIP
port: 5432
# nodePort: 30432

resources:
{}
Expand Down

0 comments on commit dd103ce

Please sign in to comment.