Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add extra-create-metadata=true on snapshot sidecar #2532

Conversation

andyzhangx
Copy link
Member

@andyzhangx andyzhangx commented Sep 20, 2024

What type of PR is this?
/kind feature

What this PR does / why we need it:
feat: add extra-create-metadata=true on snapshot sidecar

The CSI snapshotter has a new --extra-create-metadata flag.
When set to true, the name and namespace of the source VolumeSnapshot, and the name of the source VolumeSnapshotContent will be passed as parameters to the CSI driver in CreateSnapshotRequest.

Which issue(s) this PR fixes:

Fixes #

Requirements:

Special notes for your reviewer:

I0920 11:51:14.280741       1 utils.go:105] GRPC call: /csi.v1.Controller/CreateSnapshot
I0920 11:51:14.280762       1 utils.go:106] GRPC request: {"name":"snapshot-e326e8ec-d067-47c3-ac3d-20e895114c21","parameters":{"csi.storage.k8s.io/volumesnapshot/name":"snapshot-dbz7p","csi.storage.k8s.io/volumesnapshot/namespace":"snapshotting-8511","csi.storage.k8s.io/volumesnapshotcontent/name":"snapcontent-e326e8ec-d067-47c3-ac3d-20e895114c21"},"source_volume_id":"/subscriptions/46678f10-4bbb-447e-98e8-d2829589f2d8/resourceGroups/capz-jzif9q/providers/Microsoft.Compute/disks/pvc-965a1e7d-5315-4482-96d5-99c44cd36262"}
E0920 11:51:14.280910       1 utils.go:110] GRPC error: rpc error: code = Internal desc = AzureDisk - invalid option csi.storage.k8s.io/volumesnapshot/namespace in VolumeSnapshotClass

Release note:

feat: add extra-create-metadata=true on snapshot sidecar

@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Sep 20, 2024
@k8s-ci-robot k8s-ci-robot requested review from cvvz and edreed September 20, 2024 08:10
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andyzhangx

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 20, 2024
@andyzhangx andyzhangx removed the request for review from edreed September 20, 2024 08:47
@andyzhangx
Copy link
Member Author

/retest

1 similar comment
@andyzhangx
Copy link
Member Author

/retest

@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 20, 2024
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Sep 20, 2024

@andyzhangx: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-azuredisk-csi-driver-external-e2e-single-az 0044ec7 link true /test pull-azuredisk-csi-driver-external-e2e-single-az
pull-azuredisk-csi-driver-e2e-capz-windows-2022-hostprocess 0044ec7 link true /test pull-azuredisk-csi-driver-e2e-capz-windows-2022-hostprocess

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@andyzhangx andyzhangx merged commit ec99ab6 into kubernetes-sigs:master Sep 21, 2024
22 of 25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants