-
Notifications
You must be signed in to change notification settings - Fork 193
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: support attach operations after premiumV2 disk migration #2569
fix: support attach operations after premiumV2 disk migration #2569
Conversation
|
0124abf
to
3b3ce0a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/retest
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: andyzhangx, landreasyan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@landreasyan: The following tests failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
/cherrypick release-1.31 |
/cherrypick release-1.30 |
/cherrypick release-1.29 |
/cherrypick release-1.28 |
@andyzhangx: new pull request created: #2571 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
@andyzhangx: new pull request created: #2572 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
@andyzhangx: new pull request created: #2573 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
@andyzhangx: new pull request created: #2574 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
What type of PR is this?
What this PR does / why we need it:
Customers can use VAC to migrate
PremiumLRS
disks toPremiumV2LRS
disks while they are detached from the VM. While the driver already sets caching mode toNone
when it creates aPremiumV2LRS
disk, it still defaults to either the caching mode set in theVolumeContext
or toReadOnly
caching when it attaches the disk. Because caching in theVolumeContext
defaults and is set toReadOnly
forPremiumLRS
disks, to support attach operation after the migration, the driver must set the caching mode toNone
explicitly when it attaches aPremiumV2LRS
disk.Which issue(s) this PR fixes:
Fixes #
Requirements:
Special notes for your reviewer:
Release note: