Tracking issue for Improving status in CAPI resources - Phase 2

[fabriziopandini]

This is a tracking issue for activities related to #10897
Phase 1 activities are tracked into #11105

Follow up from phase 1

• Fine tuning of godocs for API types (make them kubectl explain compliant)
  - rif 📖 Proposal: Improving status in CAPI resources #10897 (comment)
• Add support for negative polarity conditions to ReadinessGates and AvailabilityGates
  • rif 📖 Proposal: Improving status in CAPI resources #10897 (review)
• Extending CC to allow the definition of AvailabilityGates & ReadinessGates (and Cluster topology)
  • rif 📖 Proposal: Improving status in CAPI resources #10897 (comment)
  • rif ✨ Add v1beta2 structs to object status #11234 (comment)
• Allow customisation of remote-conditions-grace-period at cluster level
  • rif 📖 Proposal: Improving status in CAPI resources #10897 (comment)
• Consider if to allow users to add arbitrary ReadinessGates to KCP machines
• Rename test types to align to API types (v1Beta2 in the middle)
• Check if NodeNetworkUnavailable must be added to MachineNodeHealthyCondition
• ExtensionConfig
  • Add v1beta2 struct
  • Paused
• InMemoryCluster and InMemoryMachine controllers ?
• DockerCluster and DockerMachine controllers
• MachinePool conditions
  • Implement conditions on MachinePools and MachinePool Machines (UpToDate)
  • Revert 🐛 Disable aggregation of not reported MachinePool conditions for Cluster #11416
• DockerMachinePool
  • Add v1beta2 struct
  • Paused
• Drop fake objects from controller tests and use the test/util/builders package

Implementation Phase2

Initial notes for phase 2 of the implementation, where new field are added but not yet used by controllers

• ...
• API modeling
  • Introduce deprecated struct, move v1beta2 top level
  • Rename condition interfaces and method implementations (current--> deprecated, v1beta2--> current)
  • Rename condition consts (current--> deprecated, v1beta2--> current)
  • Move conditions fields as the first field in the struct
    • rif. 📖 Proposal: Improving status in CAPI resources #10897 (comment)
  • Fine tuning of print columns
    • rif 📖 Proposal: Improving status in CAPI resources #10897 (review)
    • rif 📖 Proposal: Improving status in CAPI resources #10897 (comment)
  • Add minReadySeconds to machine, remove it from KCP. MD
• Change contracts
  • ...
• Use new fields
  • MachineHealthCheck controller
    • Change test for ControlPlaneInitializedCondition in reconcile
    • Get MachineHealthCheckSucceededCondition in patchUnhealthyTargets
    • Drop failureReson/failureMessage test from needsRemediation
    • Change test for ControlPlaneInitializedCondition, InfrastructureReadyCondition in needsRemediation (few places)
  • KCP controller
    • Change test for MachineEtcdMemberHealthyCondition in canSafelyRemoveEtcdMember + add a test for ClusterHealthy if not already there
    • We should use the Initialized condition instead of the Available condition to calculate remoteConditionsGracePeriod
• Condition utils
  • Rename packages for condition utils (conditions-->deprecated conditions, v1beta2conditions --> conditions)
• Clusterctl
  • clusterctl describe (drop v1beta2 flag, introduce deprecated flag, switch default behaviour in the implementation)

Implementation Phase3

TBD

Backlog / unprioritized

• Scale testing with CAPD (check for condition flakiness)