You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The ClusterClass webhook in PR #5717 lists all clusters and then cycles through them to find those using the clusterClass being validated. Instead the ClusterClass webhook should use index.ClusterClassNameField to pull the correct clusters directly.
This workflow is currently blocked as it requires envtest to test the indices. fakeClient does not populate indices like index.ClusterClassNameField. The index currently can't be tested as there is a circular dependency between webhooks and envtest.
The index should be added once the circular dependency with webhooks has been removed.
/area topology
I'll open the issue to remove the circular dependency ASAP
(I think we need to do this anyway to enable more realistic unit tests for the variable defaulting/validation)
The ClusterClass webhook in PR #5717 lists all clusters and then cycles through them to find those using the clusterClass being validated. Instead the ClusterClass webhook should use index.ClusterClassNameField to pull the correct clusters directly.
This workflow is currently blocked as it requires envtest to test the indices. fakeClient does not populate indices like index.ClusterClassNameField. The index currently can't be tested as there is a circular dependency between webhooks and envtest.
The index should be added once the circular dependency with webhooks has been removed.
c/f #5717 (comment)
The text was updated successfully, but these errors were encountered: