Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌱 Cleanup owner files #10642

Merged

Conversation

fabriziopandini
Copy link
Member

What this PR does / why we need it:
As reminded in this week's SIG chair and lead meeting, it is important to keep our owner files up to date.

I made a pass based on reviewer stats.

If by chance I made some error, please don't hesitate to reach out.

Let me take this moment to thank you again emeritus reviewers for all the great work in the project so far:

/area security
/hold let's give folks time to comment on this PR + I will bring it up next week in the office hour

@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. area/security Issues or PRs related to security cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels May 17, 2024
@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label May 17, 2024
@johananl
Copy link
Member

Thanks @fabriziopandini. I am still involved with CAPI but at the moment am only working on a design proposal in a Google document so not much GitHub activity lately. Personally I'm fine with being removed from the owners file. We can always reevaluate in the future if necessary.

@oscr
Copy link
Contributor

oscr commented May 20, 2024

+1

It will be a while longer before it's back to normal for me.

@stmcginnis
Copy link
Contributor

Sadly it's been awhile since I've been able to spend much time on CAPI. Maybe that will change one day, but until then:

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 20, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: f6ca1513a94cc7f7e7b1a0d27cccc0d23e7697d9

Copy link
Member

@chrischdi chrischdi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Thanks to everyone for the past contributions and happy to welcome anyone back for future contributions :-)

@sbueringer
Copy link
Member

@fabriziopandini Once we merge this PR, can we please sync back the OWNER file? Just saw that previous approvers are stil getting assigned on PRs on 1.7 + 1.6 release branches

@fabriziopandini
Copy link
Member Author

Lazy consensus expired
/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 24, 2024
@fabriziopandini
Copy link
Member Author

/cherry-pick release-1.7

@k8s-infra-cherrypick-robot

@fabriziopandini: once the present PR merges, I will cherry-pick it on top of release-1.7 in a new PR and assign it to you.

In response to this:

/cherry-pick release-1.7

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@sbueringer
Copy link
Member

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sbueringer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 24, 2024
@fabriziopandini
Copy link
Member Author

/cherry-pick release-1.6

@k8s-infra-cherrypick-robot

@fabriziopandini: once the present PR merges, I will cherry-pick it on top of release-1.6 in a new PR and assign it to you.

In response to this:

/cherry-pick release-1.6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@sbueringer
Copy link
Member

Probably will need manual cherry-picks. I think the files are already out of sync

@k8s-ci-robot k8s-ci-robot merged commit a55fc5c into kubernetes-sigs:main May 24, 2024
19 of 20 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.8 milestone May 24, 2024
@k8s-infra-cherrypick-robot

@fabriziopandini: new pull request created: #10679

In response to this:

/cherry-pick release-1.7

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-infra-cherrypick-robot

@fabriziopandini: #10642 failed to apply on top of branch "release-1.6":

Applying: Cleanup owner files
Using index info to reconstruct a base tree...
M	OWNERS_ALIASES
Falling back to patching base and 3-way merge...
Auto-merging OWNERS_ALIASES
CONFLICT (content): Merge conflict in OWNERS_ALIASES
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 Cleanup owner files
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherry-pick release-1.6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@sbueringer
Copy link
Member

Nevermind, one cherry-pick worked :D

@fabriziopandini fabriziopandini deleted the cleanup-owner-files branch June 4, 2024 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/security Issues or PRs related to security cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants