-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🌱 Cleanup owner files #10642
🌱 Cleanup owner files #10642
Conversation
Thanks @fabriziopandini. I am still involved with CAPI but at the moment am only working on a design proposal in a Google document so not much GitHub activity lately. Personally I'm fine with being removed from the owners file. We can always reevaluate in the future if necessary. |
+1 It will be a while longer before it's back to normal for me. |
Sadly it's been awhile since I've been able to spend much time on CAPI. Maybe that will change one day, but until then: /lgtm |
LGTM label has been added. Git tree hash: f6ca1513a94cc7f7e7b1a0d27cccc0d23e7697d9
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Thanks to everyone for the past contributions and happy to welcome anyone back for future contributions :-)
@fabriziopandini Once we merge this PR, can we please sync back the OWNER file? Just saw that previous approvers are stil getting assigned on PRs on 1.7 + 1.6 release branches |
Lazy consensus expired |
/cherry-pick release-1.7 |
@fabriziopandini: once the present PR merges, I will cherry-pick it on top of release-1.7 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sbueringer The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/cherry-pick release-1.6 |
@fabriziopandini: once the present PR merges, I will cherry-pick it on top of release-1.6 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Probably will need manual cherry-picks. I think the files are already out of sync |
@fabriziopandini: new pull request created: #10679 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
@fabriziopandini: #10642 failed to apply on top of branch "release-1.6":
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Nevermind, one cherry-pick worked :D |
What this PR does / why we need it:
As reminded in this week's SIG chair and lead meeting, it is important to keep our owner files up to date.
I made a pass based on reviewer stats.
If by chance I made some error, please don't hesitate to reach out.
Let me take this moment to thank you again emeritus reviewers for all the great work in the project so far:
/area security
/hold let's give folks time to comment on this PR + I will bring it up next week in the office hour