Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: change env IMAGE to KNP_IMAGE for build image. #73

Merged
merged 1 commit into from
Aug 16, 2024
Merged

chore: change env IMAGE to KNP_IMAGE for build image. #73

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ REGISTRY?=gcr.io/k8s-staging-networking
# tag based on date-sha
TAG?=$(shell echo "$$(date +v%Y%m%d)-$$(git describe --always --dirty)")
# the full image tag
IMAGE?=$(REGISTRY)/$(IMAGE_NAME):$(TAG)
KNP_IMAGE?=$(REGISTRY)/$(IMAGE_NAME):$(TAG)
PLATFORMS?=linux/amd64,linux/arm64

.PHONY: ensure-buildx
Expand All @@ -43,13 +43,13 @@ ensure-buildx:

image-build:
docker buildx build . \
--tag="${IMAGE}" \
--tag="${KNP_IMAGE}" \
--load

image-push:
docker buildx build . \
--platform="${PLATFORMS}" \
--tag="${IMAGE}" \
--tag="${KNP_IMAGE}" \
--push

.PHONY: release # Build a multi-arch docker image
Expand Down
3 changes: 3 additions & 0 deletions cloudbuild.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,4 +5,7 @@ options:
steps:
- name: gcr.io/k8s-staging-test-infra/gcb-docker-gcloud:v20240718-5ef92b5c36
entrypoint: make
env:
- REGISTRY=gcr.io/k8s-staging-networking
- IMAGE_NAME=kube-network-policies
args: ['release']
Copy link
Contributor Author

@liangyuanpeng liangyuanpeng Aug 8, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

question: do we need to get gcloud auth for docker image here?, just like gcloud auth configure-docker

cc @ameukam , thank you!

see https://github.com/kubernetes-sigs/kwok/blob/2033297e7e4bb3068b1d8ef4d240f9decab0663c/cloudbuild.yaml#L23

Loading