From 2477da970ce4e3d57cf6f89b104ef10fb6141cad Mon Sep 17 00:00:00 2001 From: Jonas-Taha El Sesiy Date: Mon, 2 Sep 2024 23:03:42 -0700 Subject: [PATCH] Fix e2e workflow syntax The workflow syntax in #93 was incorrect, `with` is not allowed for run steps --- .github/workflows/e2e.yml | 4 ++-- test/e2e/sign_test.go | 6 ++---- 2 files changed, 4 insertions(+), 6 deletions(-) diff --git a/.github/workflows/e2e.yml b/.github/workflows/e2e.yml index 0af6121d..cb1da1fe 100644 --- a/.github/workflows/e2e.yml +++ b/.github/workflows/e2e.yml @@ -54,5 +54,5 @@ jobs: echo "release sign test" > ${{ runner.temp }}/test-file-${{ github.run_id }} - name: Run e2e tests run: go run mage.go E2ETest - with: - path: ${{ runner.temp }}/test-file-${{ github.run_id }} + env: + TEST_FILE_PATH: ${{ runner.temp }}/test-file-${{ github.run_id }} diff --git a/test/e2e/sign_test.go b/test/e2e/sign_test.go index c083a708..573647b8 100644 --- a/test/e2e/sign_test.go +++ b/test/e2e/sign_test.go @@ -104,7 +104,7 @@ func TestSignFileSuccess(t *testing.T) { signer := testSigner(t) // propagated by the github actions workflow - testFilePath := os.Getenv("INPUT_PATH") + testFilePath := os.Getenv("TEST_FILE_PATH") require.NotEmpty(t, testFilePath) signedObject, err := signer.SignFile(testFilePath) require.NoError(t, err) @@ -129,7 +129,5 @@ func testSigner(t *testing.T) *sign.Signer { opts.CertIdentityRegexp = "https://github.com/kubernetes-sigs/release-sdk/.github/workflows/e2e.yml@.*" opts.CertOidcIssuer = "https://token.actions.githubusercontent.com" - signer := sign.New(opts) - - return signer + return sign.New(opts) }