Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release up-to-date sigwindowstools images #367

Open
jjmilburn opened this issue May 30, 2024 · 4 comments
Open

Release up-to-date sigwindowstools images #367

jjmilburn opened this issue May 30, 2024 · 4 comments
Labels
lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale.

Comments

@jjmilburn
Copy link

jjmilburn commented May 30, 2024

Is your feature request related to a problem? Please describe.

The images from Dockerhub that are used by the guides for Flannel in this repo appear to be out of sync with the files on the master branch here. This leads to errors related to path mismatches, e.g. the resulting script running in the pod looks for C:\hpc which does not exist.

The Windows instance is communicating to the cluster fine (shows up in kubectl, and is ready - pods are able to be assigned to it). But, the daemonset to set up Flannel fails (as does the kube-proxy one).

This is true for Containerd versions 1.7.17 and 1.7.1 on the host (Windows Server 2019).

The problem seems to be that this file: https://raw.githubusercontent.com/kubernetes-sigs/sig-windows-tools/master/hostprocess/flannel/flanneld/flannel-overlay.yml tries to pull sig-windows-tool images for flannel-hostprocess that were built quite a while ago, and don't line up with the current code in this repo.

Describe the solution you'd like
Someone following the sig-windows-tools official guide for setting up Flannel to have a working flannel configuration.

Describe alternatives you've considered

Manually installing flanneld and kube-proxy on the host without a daemonset.

Additional context

@jjmilburn
Copy link
Author

I have confirmed that building the image myself locally, and pushing it to Dockerhub, then modifying the CRD to refer to that image - works:

https://hub.docker.com/repository/docker/jjmilburn/flannel/general

The bot that builds images appears to be failing on the flannel side here.

@jjmilburn
Copy link
Author

Confirmed that this deploys successfully using the image built here: https://hub.docker.com/layers/jjmilburn/flannel/v0.22.1-hostprocess/images/sha256-e02b91da766725b37898dc7fc8eaad9aed2eb8521bebf0d1db5a1fa718bad530?context=repo

We could resolve this issue by fixing the build pipelines for the Flannel HPC image, I do not have access to the ones owned by the SIG here.

@Varorbc
Copy link

Varorbc commented Jul 29, 2024

@jjmilburn I have to build an flannel image on both Windows and Linux, but both have failed. Can you please tell me how to build an flannel image? Thank you.

@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue as fresh with /remove-lifecycle stale
  • Close this issue with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Oct 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale.
Projects
None yet
Development

No branches or pull requests

4 participants