Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aggregate-to-view RBAC for gmsacredentialspecs #161

Open
avin3sh opened this issue Nov 20, 2024 · 5 comments
Open

aggregate-to-view RBAC for gmsacredentialspecs #161

avin3sh opened this issue Nov 20, 2024 · 5 comments
Labels
sig/windows Categorizes an issue or PR as relevant to SIG Windows.

Comments

@avin3sh
Copy link

avin3sh commented Nov 20, 2024

gmsacredentialspecs doesn't contain anything sensitive and to ease cluster management we should include aggregate-to-view RBAC for gmsacredentialspecs.

Happy to send across a PR if there is an agreement.

@avin3sh avin3sh added the sig/windows Categorizes an issue or PR as relevant to SIG Windows. label Nov 20, 2024
@jsturtevant
Copy link
Contributor

This seems fine to me. @aravindhp @marosset thoughts?

@jsturtevant
Copy link
Contributor

@marosset
Copy link
Contributor

it could expose some inforamtion aroudn the layout of the network (which dns name, SID, etc). I don't think this is sensitive but could be used to craft other attacks.
I'm indifferent as to if we should expose this or not

@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue as fresh with /remove-lifecycle stale
  • Close this issue with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Feb 20, 2025
@avin3sh
Copy link
Author

avin3sh commented Feb 21, 2025

I will send a PR

/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Feb 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sig/windows Categorizes an issue or PR as relevant to SIG Windows.
Projects
None yet
Development

No branches or pull requests

5 participants