Windows CPU and Memory Affinity

[jsturtevant]

Enhancement Description

• One-line enhancement description (can be used as a release note): Add CPU and memory Affinity support to Windows nodes with CPUManager, MemoryManager and Topology manager
• Kubernetes Enhancement Proposal: KEP 4885
• Discussion Link:
  KEP-1769/KEP-3570/KEP693: Adding Windows Kubelet Manager implementation details #4738
  https://docs.google.com/document/d/1Ne57gvidMEWXR70OxxnRkYquAoMpt56o75oZtg-OeBg/edit#heading=h.ynduv79ong4u
  Provide support on Windows for CPUManagerPolicy kubernetes#125262
• Primary contact (assignee): James Sturtevant
• Responsible SIGs: sig-windows/sig-node
• Enhancement target (which target equals to which milestone):
  • Alpha release target (x.y): 1.32
  • Beta release target (x.y):
  • Stable release target (x.y):
• Alpha
  • KEP (k/enhancements) update PR(s): KEP-4885: Windows CPU and Memory Affinity #4888
  • Code (k/k) update PR(s):
    • CRI changes: CRI: Add field to support CPU affinity on Windows kubernetes#124285
    • Kubelet changes(topology and cpu manager): Support CPU and Topology manager on Windows kubernetes#125296
    • Kubelet changes (memory manager): Memory manager support for Windows nodes kubernetes#128560
    • runtimespec: Add support for windows CPU affinity opencontainers/runtime-spec#1258
  • Docs (k/website) update PR(s):
    • Docs: Windows CPU and Memory Affinity website#48469

Please keep this description up to date. This will help the Enhancement Team to track the evolution of the enhancement efficiently.

[jsturtevant]

/sig windows
/sig node

[dipesh-rawat]

Hello @jsturtevant 👋, v1.32 Enhancements team here.

Just checking in as we approach enhancements freeze on 02:00 UTC Friday 11th October 2024 / 19:00 PDT Thursday 10th October 2024.

This enhancement is targeting for stage alpha for v1.32 (correct me, if otherwise)

/stage alpha

Here's where this enhancement currently stands:

• KEP readme using the latest template has been merged into the k/enhancements repo.
• KEP status is marked as implementable for latest-milestone: v1.32.
• KEP readme has up-to-date graduation criteria
• KEP has a production readiness review that has been completed and merged into k/enhancements. (For more information on the PRR process, check here). If your production readiness review is not completed yet, please make sure to fill the production readiness questionnaire in your KEP by the PRR Freeze deadline on Thursday 3rd October 2024 so that the PRR team has enough time to review your KEP.

For this KEP, we would need to update the following:

• Create the KEP readme using the latest template and merge it in the k/enhancements repo.
• Ensure that the KEP has undergone a production readiness review and has been merged into k/enhancements.

It looks like #4888 will address most of these issues.

• Get KEP-4885: Windows CPU and Memory Affinity #4888 merged before the enhancements freeze.

The status of this enhancement is marked as at risk for enhancement freeze. Please keep the issue description up-to-date with appropriate stages as well.

If you anticipate missing enhancements freeze, you can file an exception request in advance. Thank you!

[ffromani]

/cc

[marosset]

/milestone v1.32

[dipesh-rawat]

Hi @jsturtevant 👋, v1.32 Enhancements team here.

Just a quick friendly reminder as we approach the enhancements freeze later this week, at 02:00 UTC Friday 11th October 2024 / 19:00 PDT Thursday 10th October 2024.

The current status of this enhancement is marked as at risk for enhancement freeze. There are a few requirements mentioned in the comment #4885 (comment) that still need to be completed.

If you anticipate missing enhancements freeze, you can file an exception request in advance. Thank you!

[dipesh-rawat]

Hello @jsturtevant 👋, v1.32 Enhancements team here,

Now that PR #4888 has been merged, all the KEP requirements are in place and merged into k/enhancements.

During the release cycle, it would be appreciated if following nits could be addressed:

• Update issue description to add direct link to KEP README.md.

  • Kubernetes Enhancement Proposal: https://github.com/kubernetes/enhancements/blob/master/keps/sig-windows/4885-windows-cpu-and-memory-affinity/README.md

• Ensure this issue has an assignee.

Aside from the minor nits mentioned above, this enhancement is all good for the upcoming enhancements freeze. 🚀

The status of this enhancement is now marked as tracked for enhancement freeze. Please keep the issue description up-to-date with appropriate stages as well. Thank you!

[marosset]

/assign @jsturtevant

[chanieljdan]

Hi @jsturtevant 👋, 1.32 Release Docs Lead here.

Does this enhancement work planned for 1.32 require any new docs or modification to existing docs?

If so, please follows the steps here to open a PR against dev-1.32 branch in the k/website repo. This PR can be just a placeholder at this time and must be created before Thursday October 24th 2024 18:00 PDT.

Also, take a look at Documenting for a release to get yourself familiarize with the docs requirement for the release.

Thank you!

[chanieljdan]

Hi @jsturtevant 👋, 1.32 Release Docs Lead here.

Does this enhancement work planned for 1.32 require any new docs or modification to existing docs?

If so, please follows the steps here to open a PR against dev-1.32 branch in the k/website repo. This PR can be just a placeholder at this time and must be created before Thursday October 24th 2024 18:00 PDT.

Also, take a look at Documenting for a release to get yourself familiarize with the docs requirement for the release.

Thank you!

Hi @jsturtevant 👋,

Just a reminder to open a placeholder PR against dev-1.32 branch in the k/website repo for this (steps available here). The deadline for this is a week away at Thursday October 24, 2024 18:00 PDT.

Thanks,

Daniel

[dipesh-rawat]

Hey again @jsturtevant 👋 v1.32 Enhancements team here,

Just checking in as we approach code freeze at 02:00 UTC Friday 8th November 2024 / 19:00 PDT Thursday 7th November 2024 .

Here's where this enhancement currently stands:

• All PRs to the Kubernetes repo that are related to your enhancement are linked in the above issue description (for tracking purposes).
• All PR/s are ready to be merged (they have approved and lgtm labels applied) by the code freeze deadline. This includes tests.

For this enhancement, it looks like the following PRs are open and need to be merged before code freeze (and we need to update the Issue description to include all the related PRs of this KEP):

• CRI: Add field to support CPU affinity on Windows kubernetes#124285
• Support CPU and Topology manager on Windows kubernetes#125296
• Add support for windows CPU affinity opencontainers/runtime-spec#1258

Additionally, please let me know if there are any other PRs in k/k not listed in the description or not linked with this GitHub issue that we should track for this KEP, so that we can maintain accurate status.

The status of this enhancement is marked as at risk for code freeze.

If you anticipate missing code freeze, you can file an exception request in advance. Thank you!

[wrkode]

👋 Hi there, William here from v1.32 Comms
We'd love for you to consider writing a feature blog about your enhancement! Some reasons why you might want to write a blog for this feature include (but are not limited to) if this introduces breaking changes, is important to our users, or has been in progress for a long time and is graduating.

To opt-in, let us know and open a Feature Blog placeholder PR against the website repository by 30th Oct 2024. For more information about writing a blog see the blog contribution guidelines.

Note: In your placeholder PR, use XX characters for the blog date in the front matter and file name. We will work with you on updating the PR with the publication date once we have a final number of feature blogs for this release.

[dipesh-rawat]

Hey again @jsturtevant 👋, v1.32 Enhancements team here,

Just a quick friendly reminder as we approach code freeze in few days, at 02:00 UTC Friday 8th November 2024 / 19:00 PDT Thursday 7th November 2024 .

The current status of this enhancement is marked as at risk for code freeze. There are a few requirements mentioned in the comment #4885 (comment) that still need to be completed.

If you anticipate missing code freeze, you can file an exception request in advance.

[dipesh-rawat]

Hello @jsturtevant 👋, v1.32 Enhancements team here

With all the implementation(code related) PRs merged in k/k as per the issue description:

• CRI: Add field to support CPU affinity on Windows kubernetes#124285
• Support CPU and Topology manager on Windows kubernetes#125296
• Memory manager support for Windows nodes kubernetes#128560

(Its being noted that one PR mentioned in the description that is outside of kubernetes org opencontainers/runtime-spec#1258 )

This enhancement is now marked as tracked for code freeze for the v1.32 Code Freeze!