From ff046dffbf478b23936d3af77863a594c9b728a4 Mon Sep 17 00:00:00 2001 From: Benjamin Wang Date: Tue, 4 Jun 2024 19:39:33 +0100 Subject: [PATCH] Update test case TestGroupConventions to fix sig-etcd as a special case Signed-off-by: Benjamin Wang --- groups/groups_test.go | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/groups/groups_test.go b/groups/groups_test.go index 2fc9572605a9..a90f71162e70 100644 --- a/groups/groups_test.go +++ b/groups/groups_test.go @@ -168,6 +168,11 @@ func TestGroupConventions(t *testing.T) { for _, g := range cfg.Groups { // groups are easier to reason about if email and name match expectedEmailId := g.Name + "@kubernetes.io" + // sig-etcd keeps using security@etcd.io, refer to discussion in + // https://github.com/kubernetes/k8s.io/pull/6542. + if g.Name == "etcd-security" { + expectedEmailId = "security@etcd.io" + } if g.EmailId != expectedEmailId { t.Errorf("group '%s': expected email '%s', got '%s'", g.Name, expectedEmailId, g.EmailId) }