Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New versions of govalidator changes the API validation of CRD format #512

Open
dims opened this issue Oct 16, 2024 · 0 comments
Open

New versions of govalidator changes the API validation of CRD format #512

dims opened this issue Oct 16, 2024 · 0 comments

Comments

@dims
Copy link
Member

dims commented Oct 16, 2024

Opening an issue found in a recent deps update PR:
kubernetes/kubernetes#128064 (comment)

Note from @liggitt when we tried to update to newer govalidator:
asaskevich/govalidator@f61b66f...a9d515a

these updates are problematic, they change the API validation of CRD format validators

@jpbetz @sttts @deads2k we should isolate use of these in kube-openapi and stop depending on an external library for this API
surface
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@dims