generators: Default is a valid enum value #407
Conversation
k8s-ci-robot
added
the
cncf-cla: yes
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: apelisse The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
k8s-ci-robot
added
the
size/M
apelisse
force-pushed
the
default-is-valid-enum
branch
from
f0cd309 to
a54eb54
Compare
| return fmt.Errorf("failed to generate default in %v: %v: %v", parent, m.Name, err) | ||
| } | ||
| if def != nil { | ||
| g.Do("Default: $.$,\n", *def) | ||
| if enumType, isEnum := g.enumContext.EnumType(m.Type); isEnum && !enumType.IsValid(*def) { |
There was a problem hiding this comment.
should this check be part of generateDefault implementation instead? Just wondering since it is called from multiple places and might be cleaner that way
There was a problem hiding this comment.
it would mean we would have to push even more parameters to generateDefault, I don't have a strong opinion.
There was a problem hiding this comment.
Also, I don't see IsValid being called in other places?
k8s-ci-robot
added
the
needs-rebase
|
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@alexzielenski I don't have much context on this, is it something we still want to get in? |
|
The Kubernetes project currently lacks enough contributors to adequately respond to all PRs. This bot triages PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle stale |
k8s-ci-robot
added
the
lifecycle/stale
|
The Kubernetes project currently lacks enough active contributors to adequately respond to all PRs. This bot triages PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle rotten |
k8s-ci-robot
added
lifecycle/rotten
|
The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs. This bot triages PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /close |
|
@k8s-triage-robot: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Fixes #395
This makes sure that the default value is part of the enum values, which makes sense. We shouldn't have a default that doesn't validate. There are probably a lot of other thing that don't exist right now but will exist in the future that we might want to validate for (maximum/minimum comes to mind). I'm also a little confused how we can have a default for a required value, we might want to disallow that.