Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate kOps jobs to community owned clusters #30103

Merged
merged 1 commit into from
Jul 18, 2023
Merged

Migrate kOps jobs to community owned clusters #30103

merged 1 commit into from
Jul 18, 2023

Conversation

rjsadow
Copy link
Contributor

@rjsadow rjsadow commented Jul 16, 2023

This PR transitions the kOps jobs from the default cluster to community owned clusters.

ref: #29722
xref: kubernetes/k8s.io#5127

/cc @ameukam @justinsb

@k8s-ci-robot k8s-ci-robot requested review from ameukam and justinsb July 16, 2023 19:06
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. area/config Issues or PRs related to code in /config area/jobs sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Jul 16, 2023
@rjsadow rjsadow mentioned this pull request Jul 17, 2023
Closed
54 tasks
@ameukam
Copy link
Member

ameukam commented Jul 17, 2023

kOps prowjobs depends on preset preset-aws-credential to run. I'm not sure we want to move those to the community infrastructure.

@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jul 17, 2023
@rjsadow
Copy link
Contributor Author

rjsadow commented Jul 17, 2023

I removed the jobs with the preset-aws-credentials

justinsb
justinsb reviewed Jul 17, 2023
View reviewed changes
config/jobs/kubernetes/kops/kops-presubmits.yaml Outdated
@@ -350,6 +427,7 @@ presubmits:
postsubmits:
kubernetes/kops:
- name: kops-postsubmit
cluster: eks-prow-build-cluster
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can the new cluster upload to "UPLOAD_DEST=gs://k8s-release-dev/kops/ci" ?

I suggest doing this one in a different PR.

config/jobs/kubernetes/kops/kops-presubmits.yaml
@@ -1,6 +1,7 @@
presubmits:
kubernetes/kops:
- name: pull-kops-build
cluster: eks-prow-build-cluster
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought this job uploaded, in which case credentials could be tricky, but actually it doesn't appear to do so 👍

config/jobs/kubernetes/kops/kops-presubmits.yaml Outdated
@@ -104,6 +114,7 @@ presubmits:
testgrid-dashboards: sig-cluster-lifecycle-kops, presubmits-kops, kops-presubmits
testgrid-tab-name: e2e-do-gossip
- name: pull-kops-e2e-kubernetes-do-fqdn
cluster: eks-prow-build-cluste
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we have preset-do-credential on the new cluster (?)

Also: typo in cluster name.

Suggest doing this one in a different PR.

@justinsb
Copy link
Member

Thanks for going through these @rjsadow

I suggest holding two more tests for the moment, but I think the others should be a great first step!

@justinsb
Copy link
Member

Thanks @rjsadow ... lgtm and it's a reasonable time to try it out from a kOps perspective, I believe.

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 18, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: justinsb, rjsadow

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 18, 2023
@justinsb justinsb mentioned this pull request Jul 18, 2023
Merged
@k8s-ci-robot k8s-ci-robot merged commit 617614e into kubernetes:master Jul 18, 2023
@k8s-ci-robot
Copy link
Contributor

@rjsadow: Updated the job-config configmap in namespace default at cluster test-infra-trusted using the following files:

  • key kops-presubmits.yaml using file config/jobs/kubernetes/kops/kops-presubmits.yaml

In response to this:

This PR transitions the kOps jobs from the default cluster to community owned clusters.

ref: #29722
xref: kubernetes/k8s.io#5127

/cc @ameukam @justinsb

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@justinsb justinsb justinsb left review comments

@ameukam ameukam Awaiting requested review from ameukam

Assignees

@justinsb justinsb

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config area/jobs cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rjsadow @ameukam @justinsb @k8s-ci-robot