Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: removed lowercase alphanumeric characters requirement for object naming from docs #49415

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: removed lowercase alphanumeric characters requirement for object naming from docs #49415

wants to merge 1 commit into from

Conversation

aakankshabhende
Copy link
Contributor

Description

Removed lowercase alphanumeric characters requirement for object naming from docs as per the comment #49361 (comment)

Issue

Closes: #49361

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign salaxander for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the language/en Issues or PRs related to English language label Jan 13, 2025
@k8s-ci-robot k8s-ci-robot requested a review from thockin January 13, 2025 16:44
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 13, 2025
@stmcginnis
Copy link
Contributor

I don't think we want to remove this. We still want to have the consistency of all lower case naming I think. I'm not sure if the linked issue is actually valid.

@netlify Netlify
Copy link

netlify bot commented Jan 13, 2025

✅ Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit d554721
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/678542f43339da0008967870
😎 Deploy Preview https://deploy-preview-49415--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@sftim
Copy link
Contributor

sftim commented Jan 13, 2025

The linked issue is genuinely a complaint, and I think the docs are misleading. However Kubernetes does insist that object names are lowercase and we should not direct readers to believe otherwise.

The API errors when you try to use uppercase refer to “a lowercase RFC 1123 label” or similar.

@sftim
Copy link
Contributor

sftim commented Jan 13, 2025

@aakankshabhende the docs need a fix, but the change you've suggested is not the fix we can accept

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikedanese mikedanese Awaiting requested review from mikedanese

@thockin thockin Awaiting requested review from thockin

Assignees
No one assigned
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Complaint about object naming docs
4 participants
@aakankshabhende @k8s-ci-robot @stmcginnis @sftim