Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(testkube): add custom labels and annotations through testkube-api helm chart #694

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

manidharanupoju24
Copy link

@manidharanupoju24 manidharanupoju24 commented Dec 21, 2023

Pull request description

This pull request addresses the issue: #695

Checklist (choose whats happened)

  • breaking change! (describe)
  • tested locally
  • tested on cluster
  • added new dependencies
  • updated the docs
  • added a test

Breaking changes

  • N/A

Changes

  • Added ability to specify labels and annotations for default job template via helm values.

Fixes

  • N/A

@spkane
Copy link

spkane commented Dec 21, 2023

Relates to: #695

Copy link
Contributor

@vsukhin vsukhin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

job template structture van't be changed

@spkane
Copy link

spkane commented Jan 2, 2024

@vsukhin, Can you provide a bit more detail on your thinking here?

Although this isn't our ideal approach, we did this precisely because it would not impact end users. Users can still override the job template. This makes it possible to pass helm values into the labels and annotations sections of the default job template when the user doesn't override the whole thing.

A better option might be to make it possible to pass in annotations and labels that one wants in the job templates to the operator as env vars and have it use standard go templating to apply them, but that requires touching the code, which we were trying to avoid for this particular workaround.

@vsukhin
Copy link
Contributor

vsukhin commented Jan 5, 2024

my main concern is that job template definition is splitted between template itself and configmap. so, it's no more self sufficient. I understand, that's a wroking hack, but it's not universal

@fulgas
Copy link
Contributor

fulgas commented Jan 16, 2024

This is relevant when you are using linkerd as service mesh. The jobs will not terminate unless you disable the linkerd injection and that is done thru annotations.

@spkane
Copy link

spkane commented Jan 16, 2024

@fulgas You might want to add that onto the core issue related to this: #695

@ypoplavs ypoplavs requested a review from a team as a code owner September 19, 2024 08:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants