-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(testkube): add custom labels and annotations through testkube-api helm chart #694
base: develop
Are you sure you want to change the base?
feat(testkube): add custom labels and annotations through testkube-api helm chart #694
Conversation
Relates to: #695 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
job template structture van't be changed
@vsukhin, Can you provide a bit more detail on your thinking here? Although this isn't our ideal approach, we did this precisely because it would not impact end users. Users can still override the job template. This makes it possible to pass helm values into the labels and annotations sections of the default job template when the user doesn't override the whole thing. A better option might be to make it possible to pass in annotations and labels that one wants in the job templates to the operator as env vars and have it use standard go templating to apply them, but that requires touching the code, which we were trying to avoid for this particular workaround. |
my main concern is that job template definition is splitted between template itself and configmap. so, it's no more self sufficient. I understand, that's a wroking hack, but it's not universal |
This is relevant when you are using linkerd as service mesh. The jobs will not terminate unless you disable the linkerd injection and that is done thru annotations. |
Pull request description
This pull request addresses the issue: #695
Checklist (choose whats happened)
Breaking changes
Changes
Fixes