refactor: escape quotes

kubeshop · Jan 5, 2024 · c6da331 · c6da331
1 parent ebc2539
commit c6da331
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 1 deletion.
diff --git a/packages/web/src/utils/escapeArguments.spec.ts b/packages/web/src/utils/escapeArguments.spec.ts
@@ -17,5 +17,13 @@ describe('utils', () => {
     it('should handle array with multiple arguments with spaces', () => {
       expect(escapeArguments(['ab c', 'de f'])).toEqual(['"ab c"', '"de f"']);
     });
+
+    it('should handle array with multiple arguments with quotes', () => {
+      expect(escapeArguments(['ab"c', 'de"f'])).toEqual(['ab"c', 'de"f']);
+    });
+
+    it('should handle array with multiple arguments with spaces and quotes', () => {
+      expect(escapeArguments(['ab"c', 'de f'])).toEqual(['ab"c', '"de f"']);
+    });
   });
 });
diff --git a/packages/web/src/utils/escapeArguments.ts b/packages/web/src/utils/escapeArguments.ts
@@ -1,3 +1,7 @@
 export const escapeArguments = (args: string[]) => {
-  return args.map(arg => (arg.includes(' ') ? `"${arg}"` : arg));
+  return args.map(arg => {
+    const escapedArg = arg.replace(/(")/g, '\\$1');
+
+    return /\s/.test(escapedArg) ? `"${escapedArg}"` : escapedArg;
+  });
 };