Skip to content

Commit

Permalink
fix: failed to install without image_registry (#2446)
Browse files Browse the repository at this point in the history
Signed-off-by: joyceliu <[email protected]>
Co-authored-by: joyceliu <[email protected]>
  • Loading branch information
redscholar and joyceliu authored Nov 4, 2024
1 parent 0f92f8f commit f884035
Show file tree
Hide file tree
Showing 4 changed files with 5 additions and 6 deletions.
5 changes: 2 additions & 3 deletions .github/workflows/sync-vendor.yml
Original file line number Diff line number Diff line change
Expand Up @@ -37,9 +37,8 @@ jobs:
- name: Create Pull Request
uses: peter-evans/create-pull-request@v3
with:
token: "${{ secrets.GITHUB_TOKEN }}"
commit-message: "Add vendor directory"
branch: "add-vendor-${{ github.event.number }}"
branch: "add-vendor-${{ github.sha }}"
title: "[ci-bot] Add vendor directory"
body: |
This [PR](https://github.com/kubesphere/kubekey/pull/${{ github.event.number }}) adds the vendor directory generated by go mod vendor.
This [PR](https://github.com/kubesphere/kubekey/pull/${{ github.sha }}) adds the vendor directory generated by go mod vendor.
2 changes: 1 addition & 1 deletion builtin/roles/install/cri/defaults/main.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ image_registry:
registry: |
{{- if and .image_registry.ha_vip (ne .image_registry.ha_vip "") }}
{{ .image_registry.ha_vip }}
{{- else }}
{{- else if .groups.image_registry | default list | len | lt 0 }}
{{ index .inventory_hosts (.groups.image_registry | default list | first) "internal_ipv4" }}
{{- end }}
username: admin
Expand Down
2 changes: 1 addition & 1 deletion builtin/roles/install/image-registry/defaults/main.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ image_registry:
registry: |
{{- if and .image_registry.ha_vip (ne .image_registry.ha_vip "") }}
{{ .image_registry.ha_vip }}
{{- else }}
{{- else if .groups.image_registry | default list | len | lt 0 }}
{{ index .inventory_hosts (.groups.image_registry | default list | first) "internal_ipv4" }}
{{- end }}
username: admin
Expand Down
2 changes: 1 addition & 1 deletion go.mod
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
module github.com/kubesphere/kubekey/v4

go 1.22.0
go 1.23.0

require (
github.com/Masterminds/sprig/v3 v3.2.3
Expand Down

0 comments on commit f884035

Please sign in to comment.