Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: failed to install without image_registry #2448

Merged

Conversation

redscholar
Copy link
Collaborator

What type of PR is this?

/kind bug

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Special notes for reviewers:

Does this PR introduced a user-facing change?

None

Additional documentation, usage docs, etc.:


@kubesphere-prow kubesphere-prow bot added release-note-none kind/bug Categorizes issue or PR as related to a bug. labels Nov 4, 2024
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: redscholar

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubesphere-prow kubesphere-prow bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Nov 4, 2024
@kubesphere-prow kubesphere-prow bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Nov 4, 2024
@redscholar redscholar force-pushed the feature-gitops-patch branch 2 times, most recently from 4c3493f to abbb336 Compare November 4, 2024 04:15
@kubesphere-prow kubesphere-prow bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Nov 4, 2024
Copy link

sonarcloud bot commented Nov 4, 2024

@redscholar redscholar added the lgtm Indicates that a PR is ready to be merged. label Nov 4, 2024
@kubesphere-prow kubesphere-prow bot merged commit b80c527 into kubesphere:feature-gitops Nov 4, 2024
5 checks passed
@redscholar redscholar deleted the feature-gitops-patch branch November 4, 2024 05:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. release-note-none size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant