Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: try to fix KubeSphere 4.1 docs display bugs #3204

Merged
merged 5 commits into from
Nov 1, 2024

Conversation

ROOMrepair
Copy link
Contributor

refer to #3167

@ks-ci-bot ks-ci-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Oct 31, 2024
Copy link

netlify bot commented Oct 31, 2024

Deploy Preview for kubesphere-website ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 94138d7
🔍 Latest deploy log https://app.netlify.com/sites/kubesphere-website/deploys/67244ffd305d0e0008317128
😎 Deploy Preview https://deploy-preview-3204--kubesphere-website.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@ks-ci-bot ks-ci-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 31, 2024
@ROOMrepair ROOMrepair changed the title try to fix KubeSphere 4.1 docs display bugs fix: try to fix KubeSphere 4.1 docs display bugs Oct 31, 2024
@faweizhao26
Copy link
Collaborator

/assign @zhuxiujuan28

@ks-ci-bot
Copy link
Collaborator

@faweizhao26: GitHub didn't allow me to assign the following users: zhuxiujuan28.

Note that only kubesphere members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

/assign @zhuxiujuan28

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@zhuxiujuan28
Copy link
Contributor

/approve

@zhuxiujuan28
Copy link
Contributor

/assign @faweizhao26

@faweizhao26
Copy link
Collaborator

/lgtm
/approve

@ks-ci-bot ks-ci-bot added the lgtm Indicates that a PR is ready to be merged. label Nov 1, 2024
@ks-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: faweizhao26, ROOMrepair, zhuxiujuan28

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ks-ci-bot ks-ci-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 1, 2024
@ks-ci-bot ks-ci-bot merged commit 572854a into kubesphere:master Nov 1, 2024
5 checks passed
.admon{
thead > tr > th {
padding: 0 10px;
margin: 0!important;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You could add a space.

0 !important

margin: 0!important;
height: 30px;
line-height: 30px;
color: #ffffff;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could use abbreviated color values.

color: #fff;

@@ -313,6 +332,15 @@ section {
}
}

.admon.tip {
thead > tr > th {
background: #78C578

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is best to unify the case of color values.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants