MTV-2025 | NICs mapping is unordered #1437
Conversation
|
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #1437 +/- ##
==========================================
- Coverage 15.45% 15.08% -0.37%
==========================================
Files 112 113 +1
Lines 23377 24385 +1008
==========================================
+ Hits 3613 3679 +66
- Misses 19479 20421 +942
Partials 285 285
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Hazanel
force-pushed
the
nicsOrder
branch
5 times, most recently
from
d26f0f7 to
3c8e521
Compare
pkg/controller/plan/validation.go
Outdated
| Status: True, | ||
| Reason: NotValid, | ||
| Category: Warn, | ||
| Message: "VM network mapping is unordered.", |
There was a problem hiding this comment.
VM network mapping is unordered, this can cause the interface names to be different after migration.
| if len(correctOrder) == 0 { | ||
| unEvenNicsToNetwork.Items = append(unEvenNicsToNetwork.Items, ref.String()) | ||
| } else { | ||
| unorderedNics.Message = fmt.Sprintf("%s\n Expected order: %s", unorderedNics.Message, strings.Join(correctOrder, ", ")) |
There was a problem hiding this comment.
If there will be 2+ VMs in the plan this will cause all of the VMs to have the same message.
I'm facing similar issue like this in #1436. I'll discuss this problem with another maintainer you don't need to do any changes but we will need to wait before merging this PR.
There was a problem hiding this comment.
Think we should add if len(plan.Spec.VMs) == 1 to this whole new section
Issue: When migrating VMs with multiple NICs the mapping order must match source VM order Fix: Since rhel 6 swapping/renaming devices isn't supported anymore due to kernel issues. Since we can't prevent that we will add a validation to the NICs mapping to make sure the order is correct, if not we'll issue a warning during migration plan's creation so the user will be aware and could work this around by creating the network map in the same order as source VM. Ref: https://issues.redhat.com/browse/MTV-2025 Signed-off-by: ehazan <[email protected]>
|
Issue:
When migrating VMs with multiple NICs the mapping order must match source VM order
Fix:
Since rhel 6 swapping/renaming devices isn't supported anymore due to kernel issues.
Since we can't prevent that we will add a validation to the NICs mapping to make sure the order is correct,
if not we'll issue a warning during migration plan's creation so the user will be aware and could
work this around by creating the network map in the same order as source VM.