Fix: test parameterKey can update an array #172
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Drew Wells <[email protected]>
drewwells
requested review from
FogDong,
wonderflow,
leejanee and
Somefive
as code owners
drewwells
changed the title
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #172 +/- ##
==========================================
- Coverage 67.55% 66.76% -0.80%
==========================================
Files 50 50
Lines 4553 4553
==========================================
- Hits 3076 3040 -36
- Misses 1080 1108 +28
- Partials 397 405 +8
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
Sorry for the late reply, I'm currently at the KubeConCN and will review this after I'm back. |
FogDong
reviewed
Oct 5, 2023
| @@ -74,6 +74,27 @@ func TestInput(t *testing.T) { | |||
| r.NoError(err) | |||
| r.Equal(s, `99 | |||
| `) | |||
|
|
|||
| // test array value | |||
There was a problem hiding this comment.
🤔Is this PR only for adding test cases?
|
Yeah, I thought it was going to uncover a bug but workflow handles arrays just fine. So this tests that arrays work. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
ref #171
I have:
make reviewableto ensure this PR is ready for review.backport release-x.ylabels to auto-backport this PR if necessary.How has this code been tested
It's a test
Special notes for your reviewer
Unit test to enforce issue we found in kubevela/[email protected]