Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tuning parameter k2 #17

Open
lyn-max opened this issue Mar 1, 2021 · 2 comments
Open

tuning parameter k2 #17

lyn-max opened this issue Mar 1, 2021 · 2 comments

Comments

@lyn-max
Copy link

lyn-max commented Mar 1, 2021

Hi,

  1. I'm curious that in the paper k2h = kDetail / (kShrink * A), but in your implementation k2h = kDetail / kShrink * A, why did you modified it?
  2. From formula derivation is [c,s]T corresponding to k1, and [s,-c]T corresponding to k2? Also, in your implementation they were reversed.

regards max

@kunzmi
Copy link
Owner

kunzmi commented Mar 2, 2021

Hi Max,

good question, it has been a while that I was fighting with these equations ;-)
I was checking for my notes from that time but I didn't find them, at least the part of interest is missing... So I have to rely on my memories:

  1. I don't remember if I had a specific mathematical reason for that or just try and error. Given that the formula for A was already wrong the following isn't really reliable. I remember though that I tried to reproduce the kernels of figure 8 in the main paper and if I didn't mess up things, the code should reproduce these kernels (whereas the kernel in the figure seems normalized, so only the shape and ratios count).
  2. yes, I changed these, otherwise your kernel is transposed. At the end the only question is, if your kernel is a row first or a column first matrix, or if you flip x and y, etc. Maybe my indexation is wrong, mayber there's, I didn't check that, all I wanted is that the kernel shown in the GUI matches the edges and that the calculations are correct, which should be the case.

Cheers,
Michael

@lyn-max
Copy link
Author

lyn-max commented Mar 3, 2021

@kunzmi thanks for your excellent work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants