Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

functional correctness question #7

Open
alex-111-gh opened this issue Apr 26, 2020 · 1 comment
Open

functional correctness question #7

alex-111-gh opened this issue Apr 26, 2020 · 1 comment

Comments

@alex-111-gh
Copy link

Are there tests that verify functional correctness overall and of individual steps?

In other words, does it work? :)

@kunzmi
Copy link
Owner

kunzmi commented Apr 26, 2020

Well, I wasn't aiming for industrial code quality when implementing :)
So no, there are no unit tests, no tests suits for no regression or what so ever. All I wanted is to check the algorithm given my doubts due to the lack of quality in the paper… The existence of that GUI is, on the other hand, only to help me to get things right, to easily visualize the output of every single step, the different weights, the shifts, the tiles, and so on.
You can manipulate basically all parameters that are used; that gives you a lot of power and allows you to mess things up. I spent a lot of time to ensure that it does actually work, if the parameters are right.
In short, I tested and debugged a lot, I'm certain that the individual functions do what I want them to do. But I can't ensure that what I want is correct as there's no reference implementation…

And the images I tested worked well, too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants