Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Give the test component a dependency on base #5

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

Give the test component a dependency on base #5

wants to merge 8 commits into from

Conversation

robrix
Copy link

@robrix robrix commented Jul 18, 2020

robrix
robrix commented Jul 18, 2020
View reviewed changes
Copy link
Author

@robrix robrix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ready for review, modulo dependencies on #2 and #4.

opentype.cabal
@@ -57,3 +57,4 @@ test-suite test
main-is: test.hs
buildable: True
hs-source-dirs: tests
build-depends: base
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the only change from this particular PR.

@robrix robrix mentioned this pull request Oct 4, 2024
Open
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@robrix