This repository has been archived by the owner on Oct 21, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 1
feat: Topology node list of versions containing flow id, image tag and baseline flag #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laurentluce
changed the title
feat: Node list of versions containing flow id, image tag and baseline flag
feat: Topology node list of versions containing flow id, image tag and baseline flag
Sep 17, 2024
skylarmb
reviewed
Sep 17, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I assume some changes are required here to address my comment on the types changes: kurtosis-tech/kardinal#228 (review)
Overall response looks good except for the JSON encoding for the keys, see above comment.
skylarmb
approved these changes
Sep 18, 2024
Updating the cli kontrol api dep was the only change required here. Here is the latest output:
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The node list of version strings is replaced with a list of flow id, image tag and baseline flag maps. The image tag is set to null for external services.
https://www.notion.so/kurtosistech/Topology-API-and-UI-improvements-91a422b818eb478296912b6797b9e9bc
Node versions type update: kurtosis-tech/kardinal#228
/topology
response example: