You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Nov 27, 2021. It is now read-only.
As it stands, the regenerate-protobuf-output.sh isn't part of the CI build chain. This means that users need to run it locally on their machine to regenerate the Protobuf bindings. However, once we have more than one developer, this means that the output will be nondeterministic.
To fix, we need to push the Protobuf binding generation into the Docker build step; this is pain because we'll both need to generate the bindings locally (so the user's IDE doesn't get confused by missing files) as well as generate them inside the Docker image as the lib is built.
As it stands, the
regenerate-protobuf-output.sh
isn't part of the CI build chain. This means that users need to run it locally on their machine to regenerate the Protobuf bindings. However, once we have more than one developer, this means that the output will be nondeterministic.To fix, we need to push the Protobuf binding generation into the Docker build step; this is pain because we'll both need to generate the bindings locally (so the user's IDE doesn't get confused by missing files) as well as generate them inside the Docker image as the lib is built.
When this is done, we can get rid of https://github.com/kurtosis-tech/rust-protobuf-binding-generator
The text was updated successfully, but these errors were encountered: