Skip to content

Commit

Permalink
fix: wrong config structure for release please (#2588)
Browse files Browse the repository at this point in the history
## Description
Tested in here skylenet/release-tests#3

With this change we'll get rid of the `v` prefix on tags.

## REMINDER: Tag Reviewers, so they get notified to review

## Is this change user facing?
NO
<!-- If yes, please add the "user facing" label to the PR -->
<!-- If yes, don't forget to include docs changes where relevant -->

## References (if applicable)
<!-- Add relevant Github Issues, Discord threads, or other helpful
information. -->
<!-- You can auto-close issues by putting "Fixes #XXXX" here. -->
  • Loading branch information
skylenet authored Nov 1, 2024
1 parent a87f945 commit e7263c3
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 5 deletions.
1 change: 0 additions & 1 deletion .github/workflows/release-please.yml
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,5 @@ jobs:
# can run on the PR created
# https://github.com/kurtosis-tech/kurtosis/issues/688
token: "${{ secrets.RELEASER_TOKEN }}"
release-type: simple
config-file: release-please-config.json
manifest-file: .release-please-manifest.json
10 changes: 6 additions & 4 deletions release-please-config.json
Original file line number Diff line number Diff line change
@@ -1,10 +1,12 @@
{
"$schema": "https://raw.githubusercontent.com/googleapis/release-please/main/schemas/config.json",
"release-type": "simple",
"bump-minor-pre-major": false,
"bump-patch-for-minor-pre-major": false,
"include-v-in-tag": false,
"packages": {
".": {
"package-name": "kurtosis",
"bump-minor-pre-major": false,
"bump-path-for-minor-pre-major": false,
"include-v-in-tag": false
"package-name": "kurtosis"
}
}
}

0 comments on commit e7263c3

Please sign in to comment.