Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using upload_files through GitHub URL doesn't copy the exact code #2538

Open
nidhi-singh02 opened this issue Aug 24, 2024 · 3 comments
Open
Labels
bug Something isn't working cli For bugs relating to the CLI critical Critical bug or feature

Comments

@nidhi-singh02
Copy link

nidhi-singh02 commented Aug 24, 2024

What's your CLI version?

1.1.0

Description & steps to reproduce

I am using plan.upload_files with a private GitHub URL, the code doesn't get copied as it is. I see some parts are missing, it is a solidity file.

Desired behavior

Files should get copied inside enclave as is.

What is the severity of this bug?

Critical; I am blocked and Kurtosis is unusable for me because of this bug.

What area of the product does this pertain to?

CLI: the Command Line Interface

@nidhi-singh02 nidhi-singh02 added the bug Something isn't working label Aug 24, 2024
@github-actions github-actions bot added cli For bugs relating to the CLI critical Critical bug or feature labels Aug 24, 2024
@tedim52
Copy link
Contributor

tedim52 commented Sep 4, 2024

Hey @nidhi-singh02 would you mind expanding on this? Could you give me an example of the github URL/how you are referencing it? Is it referencing a package (upload_files only allows referencing kurtosis packages, not arbitrary urls) Additionally, if you are referring to a private GitHub URL - are you authenticated via kurtosis github login to access that private github url?

@nidhi-singh02
Copy link
Author

Sure, unfortunately I cannot share the GitHub URL as it is private repository. Yes, I am using upload_files - I read in the documentation that it works for any GitHub URL irrespective of it being a kurtosis package. Let me know if my understanding needs correction. What I understand is whatever is being uploaded, is stored inside the enclave.

Yes, I am authenticated via kurtosis github login.

@tedim52
Copy link
Contributor

tedim52 commented Nov 12, 2024

Hey @nidhi-singh02 let me know if you were able to solve this - I'm happy to iterate with you over Discord to see why all files aren't being copied. Feel free to send me a friend request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working cli For bugs relating to the CLI critical Critical bug or feature
Projects
None yet
Development

No branches or pull requests

2 participants