fix: clean em api get service logs streaming logic #1589
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tedim52
changed the title
tedim52
changed the title
tedim52
changed the title
adschwartz
approved these changes
Oct 24, 2023
There was a problem hiding this comment.
@tedim52 if this merges after another build of the EM UI, you'll need to rebuild the EM UI (npm run build).
github-merge-queue bot
pushed a commit
that referenced
this pull request
Oct 24, 2023
🤖 I have created a release *beep* *boop* --- ## [0.84.11](0.84.10...0.84.11) (2023-10-24) ### Features * add full story script ([#1610](#1610)) ([de10c7b](de10c7b)) * allow for named artifact creation in run_sh and run_python ([#1608](#1608)) ([1a9d953](1a9d953)), closes [#1581](#1581) * disable smooth scrolling for logs and default to select restart services ([#1612](#1612)) ([2ee86c4](2ee86c4)) ### Bug Fixes * clean em api get service logs streaming logic ([#1589](#1589)) ([f8d8bda](f8d8bda)) * show container status instead of service status in UI ([#1567](#1567)) ([4b75980](4b75980)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Co-authored-by: kurtosisbot <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This change improves naming, error handling, of some enclave manager server code.
Is this change user facing?
NO