Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Importing a CSV into an existing table without a header fails #197

Closed
benjaminwinger opened this issue Aug 14, 2024 · 2 comments
Closed
Assignees

Comments

@benjaminwinger
Copy link

benjaminwinger commented Aug 14, 2024

E.g. importing tinysnb (vPerson2.csv), starting by creating the schema using the shell.
It just complains that each column is missing the column name (e.g. Column 0 in table person is missing column name).

And for files with a header (e.g. vPerson.csv) the header appears to need to match the case of the properties, unlike copying from the command line.

@mewim mewim self-assigned this Aug 14, 2024
@mewim
Copy link
Member

mewim commented Aug 15, 2024

I think in both cases, if you set the column names manually from the dropdown, it will still works, but the default settings does not setup all the fields automatically (as shown below).

Screenshot 2024-08-14 at 10 29 29 PM

For case 2, I think it is reasonable to make the UI case insensitive similar to the shell, I implmented this change in #200. However, for case 1, I do not think it is safe to assume that the column order in the file is the same as the table. I would prefer that the user always review and select manually in this case to avoid unexpected behavior.

@mewim mewim closed this as completed Aug 15, 2024
@mewim
Copy link
Member

mewim commented Aug 15, 2024

Also, it seems that the dropdown for column configurations is not obvious. I am not sure if we should just expand everything by default? @semihsalihoglu-uw or @prrao87 can comment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants