Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Plan for new release 5.2.0 #2576

Closed
ctrlaltca opened this issue Dec 6, 2023 · 10 comments
Closed

Plan for new release 5.2.0 #2576

ctrlaltca opened this issue Dec 6, 2023 · 10 comments

Comments

@ctrlaltca
Copy link
Contributor

I guess it's about time to plan for a new release.
The 5.0 release contains a lot of known bugs, even crash bugs, thta have been fixed since a long time in master.
It could be 5.0.1, but a lot of nightlies already use that version, so i guess 5.1.0 would be more appropriate.
What blockers do we want to fix before drafting the release?
@wodim
Copy link
Member

wodim commented Dec 6, 2023 •
edited
Loading

Doesn't KVIrc use even numbers for stable releases? Thus it should be 5.2.0.

@ctrlaltca
Copy link
Contributor Author

Correct, 5.2.0.

@ctrlaltca
Copy link
Contributor Author

Shall we go for a "beta1" like 5.1.1, push it as a prerelease and ask feedback from bug tickets?

@DarthGandalf
Copy link
Member

DarthGandalf commented Dec 6, 2023 via email

@ctrlaltca ctrlaltca mentioned this issue Dec 6, 2023
Merged
@ctrlaltca ctrlaltca changed the title Plan for a new release Plan for new release 5.2.0 Dec 7, 2023
@ctrlaltca
Copy link
Contributor Author

So, a little recap from the last few days.
Beta 1 was published, but it was noticed that it didn't detect the correct tag; a problem in the build scripts was fixed in 30fc8596f77d38408b9234e6fb5ef7a5ceef6d41and a beta1-fix was released shortly after.

Since beta1, a couple of problems have been detected:

Beta2 was released with these fixes included.

@ctrlaltca ctrlaltca pinned this issue Dec 24, 2023
@ctrlaltca
Copy link
Contributor Author

ctrlaltca commented Dec 26, 2023 •
edited
Loading

Update: beta3 released at https://github.com/kvirc/KVIrc/releases/tag/5.2.0-beta3
It contains a few more fixes since beta2:

The new beta adopted the name "Quasar"; this name was already a candidate as noted in cmakelists.txt. The new artwork has been introduced in #2584

@ctrlaltca
Copy link
Contributor Author

Update: no new reports of crashes since beta1.
A couple of changed were merged in:

#2590 is ready to be merged when CI goes green, 5.2.0 tagged etc..

@Dessa
Copy link
Member

Dessa commented Jan 8, 2024 •
edited
Loading

i don't suppose qt6 on windows is a blocker for this, but just in case someone wants to look at that before release:

qt 6.6.1 from vcpkg 
[386/1166] Automatic MOC for target kvilib
AutoMoc: D:/dev/src/KVIrc/src/kvilib/ext/KviDbusAdaptor.h: note: No relevant classes found. No output generated.
AutoMoc: D:/dev/src/KVIrc/src/kvilib/system/KviSignalHandler.h: note: No relevant classes found. No output generated.
[387/1166] Building CXX object src\kvilib\CMakeFiles\kvilib.dir\core\KviHeapObject.cpp.obj
D:\dev\src\KVIrc\src\kvilib\config\kvi_settings.h(197): warning C4005: 'UNICODE': macro redefinition
D:\dev\src\KVIrc\src\kvilib\config\kvi_settings.h(197): note: 'UNICODE' previously declared on the command line
D:\dev\src\KVIrc\src\kvilib\config\kvi_settings.h(198): warning C4005: '_UNICODE': macro redefinition
D:\dev\src\KVIrc\src\kvilib\config\kvi_settings.h(198): note: '_UNICODE' previously declared on the command line
[388/1166] Building CXX object src\kvilib\CMakeFiles\kvilib.dir\ext\KviDataBuffer.cpp.obj
D:\dev\src\KVIrc\src\kvilib\config\kvi_settings.h(197): warning C4005: 'UNICODE': macro redefinition
D:\dev\src\KVIrc\src\kvilib\config\kvi_settings.h(197): note: 'UNICODE' previously declared on the command line
D:\dev\src\KVIrc\src\kvilib\config\kvi_settings.h(198): warning C4005: '_UNICODE': macro redefinition
D:\dev\src\KVIrc\src\kvilib\config\kvi_settings.h(198): note: '_UNICODE' previously declared on the command line
[389/1166] Building CXX object src\kvilib\CMakeFiles\kvilib.dir\core\KviMemory.cpp.obj
D:\dev\src\KVIrc\src\kvilib\config\kvi_settings.h(197): warning C4005: 'UNICODE': macro redefinition
D:\dev\src\KVIrc\src\kvilib\config\kvi_settings.h(197): note: 'UNICODE' previously declared on the command line
D:\dev\src\KVIrc\src\kvilib\config\kvi_settings.h(198): warning C4005: '_UNICODE': macro redefinition
D:\dev\src\KVIrc\src\kvilib\config\kvi_settings.h(198): note: '_UNICODE' previously declared on the command line
[390/1166] Building CXX object src\kvilib\CMakeFiles\kvilib.dir\ext\KviDbusAdaptor.cpp.obj
D:\dev\src\KVIrc\src\kvilib\config\kvi_settings.h(197): warning C4005: 'UNICODE': macro redefinition
D:\dev\src\KVIrc\src\kvilib\config\kvi_settings.h(197): note: 'UNICODE' previously declared on the command line
D:\dev\src\KVIrc\src\kvilib\config\kvi_settings.h(198): warning C4005: '_UNICODE': macro redefinition
D:\dev\src\KVIrc\src\kvilib\config\kvi_settings.h(198): note: '_UNICODE' previously declared on the command line
[391/1166] Building CXX object src\kvilib\CMakeFiles\kvilib.dir\config\KviBuildInfo.cpp.obj
D:\dev\src\KVIrc\src\kvilib\config\kvi_settings.h(197): warning C4005: 'UNICODE': macro redefinition
D:\dev\src\KVIrc\src\kvilib\config\kvi_settings.h(197): note: 'UNICODE' previously declared on the command line
D:\dev\src\KVIrc\src\kvilib\config\kvi_settings.h(198): warning C4005: '_UNICODE': macro redefinition
D:\dev\src\KVIrc\src\kvilib\config\kvi_settings.h(198): note: '_UNICODE' previously declared on the command line
[392/1166] Building CXX object src\kvilib\CMakeFiles\kvilib.dir\core\KviCString.cpp.obj
D:\dev\src\KVIrc\src\kvilib\config\kvi_settings.h(197): warning C4005: 'UNICODE': macro redefinition
D:\dev\src\KVIrc\src\kvilib\config\kvi_settings.h(197): note: 'UNICODE' previously declared on the command line
D:\dev\src\KVIrc\src\kvilib\config\kvi_settings.h(198): warning C4005: '_UNICODE': macro redefinition
D:\dev\src\KVIrc\src\kvilib\config\kvi_settings.h(198): note: '_UNICODE' previously declared on the command line
[393/1166] Building CXX object src\kvilib\CMakeFiles\kvilib.dir\ext\KviCryptEngineManager.cpp.obj
D:\dev\src\KVIrc\src\kvilib\config\kvi_settings.h(197): warning C4005: 'UNICODE': macro redefinition
D:\dev\src\KVIrc\src\kvilib\config\kvi_settings.h(197): note: 'UNICODE' previously declared on the command line
D:\dev\src\KVIrc\src\kvilib\config\kvi_settings.h(198): warning C4005: '_UNICODE': macro redefinition
D:\dev\src\KVIrc\src\kvilib\config\kvi_settings.h(198): note: '_UNICODE' previously declared on the command line
[394/1166] Building CXX object src\kvilib\CMakeFiles\kvilib.dir\ext\KviMessageTypeSettings.cpp.obj
D:\dev\src\KVIrc\src\kvilib\config\kvi_settings.h(197): warning C4005: 'UNICODE': macro redefinition
D:\dev\src\KVIrc\src\kvilib\config\kvi_settings.h(197): note: 'UNICODE' previously declared on the command line
D:\dev\src\KVIrc\src\kvilib\config\kvi_settings.h(198): warning C4005: '_UNICODE': macro redefinition
D:\dev\src\KVIrc\src\kvilib\config\kvi_settings.h(198): note: '_UNICODE' previously declared on the command line
[395/1166] Building CXX object src\kvilib\CMakeFiles\kvilib.dir\ext\KviCommandFormatter.cpp.obj
D:\dev\src\KVIrc\src\kvilib\config\kvi_settings.h(197): warning C4005: 'UNICODE': macro redefinition
D:\dev\src\KVIrc\src\kvilib\config\kvi_settings.h(197): note: 'UNICODE' previously declared on the command line
D:\dev\src\KVIrc\src\kvilib\config\kvi_settings.h(198): warning C4005: '_UNICODE': macro redefinition
D:\dev\src\KVIrc\src\kvilib\config\kvi_settings.h(198): note: '_UNICODE' previously declared on the command line
[396/1166] Building CXX object src\kvilib\CMakeFiles\kvilib.dir\ext\KviCryptEngine.cpp.obj
D:\dev\src\KVIrc\src\kvilib\config\kvi_settings.h(197): warning C4005: 'UNICODE': macro redefinition
D:\dev\src\KVIrc\src\kvilib\config\kvi_settings.h(197): note: 'UNICODE' previously declared on the command line
D:\dev\src\KVIrc\src\kvilib\config\kvi_settings.h(198): warning C4005: '_UNICODE': macro redefinition
D:\dev\src\KVIrc\src\kvilib\config\kvi_settings.h(198): note: '_UNICODE' previously declared on the command line
[397/1166] Building CXX object src\kvilib\CMakeFiles\kvilib.dir\ext\KviDebugContext.cpp.obj
D:\dev\src\KVIrc\src\kvilib\config\kvi_settings.h(197): warning C4005: 'UNICODE': macro redefinition
D:\dev\src\KVIrc\src\kvilib\config\kvi_settings.h(197): note: 'UNICODE' previously declared on the command line
D:\dev\src\KVIrc\src\kvilib\config\kvi_settings.h(198): warning C4005: '_UNICODE': macro redefinition
D:\dev\src\KVIrc\src\kvilib\config\kvi_settings.h(198): note: '_UNICODE' previously declared on the command line
[398/1166] Building CXX object src\kvilib\CMakeFiles\kvilib.dir\core\KviShortcut.cpp.obj
D:\dev\src\KVIrc\src\kvilib\config\kvi_settings.h(197): warning C4005: 'UNICODE': macro redefinition
D:\dev\src\KVIrc\src\kvilib\config\kvi_settings.h(197): note: 'UNICODE' previously declared on the command line
D:\dev\src\KVIrc\src\kvilib\config\kvi_settings.h(198): warning C4005: '_UNICODE': macro redefinition
D:\dev\src\KVIrc\src\kvilib\config\kvi_settings.h(198): note: '_UNICODE' previously declared on the command line
[399/1166] Building CXX object src\kvilib\CMakeFiles\kvilib.dir\core\KviError.cpp.obj
D:\dev\src\KVIrc\src\kvilib\config\kvi_settings.h(197): warning C4005: 'UNICODE': macro redefinition
D:\dev\src\KVIrc\src\kvilib\config\kvi_settings.h(197): note: 'UNICODE' previously declared on the command line
D:\dev\src\KVIrc\src\kvilib\config\kvi_settings.h(198): warning C4005: '_UNICODE': macro redefinition
D:\dev\src\KVIrc\src\kvilib\config\kvi_settings.h(198): note: '_UNICODE' previously declared on the command line
[400/1166] Building CXX object src\kvilib\CMakeFiles\kvilib.dir\core\KviQString.cpp.obj
D:\dev\src\KVIrc\src\kvilib\config\kvi_settings.h(197): warning C4005: 'UNICODE': macro redefinition
D:\dev\src\KVIrc\src\kvilib\config\kvi_settings.h(197): note: 'UNICODE' previously declared on the command line
D:\dev\src\KVIrc\src\kvilib\config\kvi_settings.h(198): warning C4005: '_UNICODE': macro redefinition
D:\dev\src\KVIrc\src\kvilib\config\kvi_settings.h(198): note: '_UNICODE' previously declared on the command line
[401/1166] Building CXX object src\kvilib\CMakeFiles\kvilib.dir\kvilib_autogen\mocs_compilation.cpp.obj
FAILED: src/kvilib/CMakeFiles/kvilib.dir/kvilib_autogen/mocs_compilation.cpp.obj
C:\PROGRA~1\MICROS~4\2022\COMMUN~1\VC\Tools\MSVC\1438~1.331\bin\Hostx64\x64\cl.exe  /nologo /TP -DMSVC -DNOMINMAX -DQT_CONCURRENT_LIB -DQT_CORE5COMPAT_LIB -DQT_CORE_LIB -DQT_GUI_LIB -DQT_MULTIMEDIA_LIB -DQT_NETWORK_LIB -DQT_NO_DEBUG -DQT_PRINTSUPPORT_LIB -DQT_SQL_LIB -DQT_SVG_LIB -DQT_WIDGETS_LIB -DQT_XML_LIB -DUNICODE -DWIN32 -DWIN32_LEAN_AND_MEAN -DWIN64 -DWINVER=0x0601 -D_CRT_SECURE_CPP_OVERLOAD_STANDARD_NAMES -D_ENABLE_EXTENDED_ALIGNED_STORAGE -D_UNICODE -D_WANT_KVILIB_ -D_WIN32_WINNT=0x0601 -D_WIN64 -Dkvilib_EXPORTS -ID:\dev\src\KVIrc\build\src\kvilib\kvilib_autogen\include -ID:\dev\src\vcpkg\installed\x64-windows\include -ID:\dev\src\vcpkg\installed\x64-windows\include\openssl -ID:\dev\src\vcpkg\installed\x64-windows\include\..\ms -IC:\Users\Kuja\AppData\Local\Programs\Python\Python311\include -ID:\dev\src\KVIrc\build -ID:\dev\src\KVIrc\src\kvilib\config -ID:\dev\src\KVIrc\src\kvilib\core -ID:\dev\src\KVIrc\src\kvilib\ext -ID:\dev\src\KVIrc\src\kvilib\file -ID:\dev\src\KVIrc\src\kvilib\irc -ID:\dev\src\KVIrc\src\kvilib\locale -ID:\dev\src\KVIrc\src\kvilib\net -ID:\dev\src\KVIrc\src\kvilib\system -external:ID:\dev\src\vcpkg\installed\x64-windows\include\Qt6\QtWidgets -external:ID:\dev\src\vcpkg\installed\x64-windows\include\Qt6 -external:ID:\dev\src\vcpkg\installed\x64-windows\include\Qt6\QtCore -external:ID:\dev\src\vcpkg\installed\x64-windows\include\Qt6\QtGui -external:ID:\dev\src\vcpkg\installed\x64-windows\include\Qt6\QtCore5Compat -external:ID:\dev\src\vcpkg\installed\x64-windows\include\Qt6\QtSql -external:ID:\dev\src\vcpkg\installed\x64-windows\include\Qt6\QtXml -external:ID:\dev\src\vcpkg\installed\x64-windows\include\Qt6\QtNetwork -external:ID:\dev\src\vcpkg\installed\x64-windows\include\Qt6\QtPrintSupport -external:ID:\dev\src\vcpkg\installed\x64-windows\include\Qt6\QtMultimedia -external:ID:\dev\src\vcpkg\installed\x64-windows\include\Qt6\QtConcurrent -external:ID:\dev\src\vcpkg\installed\x64-windows\include\Qt6\QtSvg -external:ID:\dev\src\vcpkg\installed\x64-windows\share\Qt6\mkspecs\win32-msvc -external:W0 /MP /Zc:wchar_t /EHsc /utf-8 /O2 /Gw /O2 /Ob2 /DNDEBUG -std:c++17 -MD -Zc:__cplusplus -permissive- -utf-8 /showIncludes /Fosrc\kvilib\CMakeFiles\kvilib.dir\kvilib_autogen\mocs_compilation.cpp.obj /Fdsrc\kvilib\CMakeFiles\kvilib.dir\ /FS -c D:\dev\src\KVIrc\build\src\kvilib\kvilib_autogen\mocs_compilation.cpp
D:\dev\src\KVIrc\src\kvilib\config\kvi_settings.h(197): warning C4005: 'UNICODE': macro redefinition
D:\dev\src\KVIrc\src\kvilib\config\kvi_settings.h(197): note: 'UNICODE' previously declared on the command line
D:\dev\src\KVIrc\src\kvilib\config\kvi_settings.h(198): warning C4005: '_UNICODE': macro redefinition
D:\dev\src\KVIrc\src\kvilib\config\kvi_settings.h(198): note: '_UNICODE' previously declared on the command line
D:\dev\src\vcpkg\installed\x64-windows\include\Qt6\QtCore/qmetatype.h(2417): error C2665: 'KviHeapObject::operator new': no overloaded function could convert all the argument types
D:\dev\src\KVIrc\src\kvilib\core\KviHeapObject.h(113): note: could be 'void *KviHeapObject::operator new(size_t,const char *,int)'
D:\dev\src\vcpkg\installed\x64-windows\include\Qt6\QtCore/qmetatype.h(2417): note: 'void *KviHeapObject::operator new(size_t,const char *,int)': cannot convert argument 2 from 'std::align_val_t' to 'const char *'
D:\dev\src\vcpkg\installed\x64-windows\include\Qt6\QtCore/qmetatype.h(2417): note: Conversion from integral type to pointer type requires reinterpret_cast, C-style cast or parenthesized function-style cast
D:\dev\src\vcpkg\installed\x64-windows\include\Qt6\QtCore/qmetatype.h(2417): note: while trying to match the argument list '(unsigned __int64, std::align_val_t, void *)'
D:\dev\src\vcpkg\installed\x64-windows\include\Qt6\QtCore/qmetatype.h(2417): note: the template instantiation context (the oldest one first) is
D:\dev\src\KVIrc\build\src\kvilib\kvilib_autogen\OPB47W6Z4I/moc_KviCryptEngine.cpp(82): note: see reference to variable template 'const QtPrivate::QMetaTypeInterface *const qt_incomplete_metaTypeArray<`anonymous namespace'::qt_meta_stringdata_CLASSKviCryptEngineENDCLASS_t,QtPrivate::TypeAndForceComplete<KviCryptEngine,std::integral_constant<bool,1> > >[1]' being compiled
D:\dev\src\vcpkg\installed\x64-windows\include\Qt6\QtCore/qmetatype.h(2668): note: see reference to function template instantiation 'const QtPrivate::QMetaTypeInterface *QtPrivate::qTryMetaTypeInterfaceForType<`anonymous-namespace'::qt_meta_stringdata_CLASSKviCryptEngineENDCLASS_t,QtPrivate::TypeAndForceComplete<KviCryptEngine,std::true_type>>(void)' being compiled
D:\dev\src\vcpkg\installed\x64-windows\include\Qt6\QtCore/qmetatype.h(2598): note: see reference to class template instantiation 'QtPrivate::QMetaTypeInterfaceWrapper<Ty>' being compiled
D:\dev\src\vcpkg\installed\x64-windows\include\Qt6\QtCore/qmetatype.h(2487): note: see reference to class template instantiation 'QtPrivate::QMetaTypeForType<T>' being compiled
        with
        [
            T=Ty
        ]
D:\dev\src\vcpkg\installed\x64-windows\include\Qt6\QtCore/qmetatype.h(2414): note: while compiling class template member function 'QtPrivate::QMetaTypeInterface::DefaultCtrFn QtPrivate::QMetaTypeForType<T>::getDefaultCtr(void)'
        with
        [
            T=Ty
        ]
D:\dev\src\vcpkg\installed\x64-windows\include\Qt6\QtCore/qmetatype.h(2417): fatal error C1903: unable to recover from previous error(s); stopping compilation
[402/1166] Building CXX object src\kvilib\CMakeFiles\kvilib.dir\ext\KviMiscUtils.cpp.obj
D:\dev\src\KVIrc\src\kvilib\config\kvi_settings.h(197): warning C4005: 'UNICODE': macro redefinition
D:\dev\src\KVIrc\src\kvilib\config\kvi_settings.h(197): note: 'UNICODE' previously declared on the command line
D:\dev\src\KVIrc\src\kvilib\config\kvi_settings.h(198): warning C4005: '_UNICODE': macro redefinition
D:\dev\src\KVIrc\src\kvilib\config\kvi_settings.h(198): note: '_UNICODE' previously declared on the command line
[403/1166] Building CXX object src\kvilib\CMakeFiles\kvilib.dir\ext\KviConfigurationFile.cpp.obj
D:\dev\src\KVIrc\src\kvilib\config\kvi_settings.h(197): warning C4005: 'UNICODE': macro redefinition
D:\dev\src\KVIrc\src\kvilib\config\kvi_settings.h(197): note: 'UNICODE' previously declared on the command line
D:\dev\src\KVIrc\src\kvilib\config\kvi_settings.h(198): warning C4005: '_UNICODE': macro redefinition
D:\dev\src\KVIrc\src\kvilib\config\kvi_settings.h(198): note: '_UNICODE' previously declared on the command line
[404/1166] Building CXX object src\kvilib\CMakeFiles\kvilib.dir\ext\KviPixmap.cpp.obj
D:\dev\src\KVIrc\src\kvilib\config\kvi_settings.h(197): warning C4005: 'UNICODE': macro redefinition
D:\dev\src\KVIrc\src\kvilib\config\kvi_settings.h(197): note: 'UNICODE' previously declared on the command line
D:\dev\src\KVIrc\src\kvilib\config\kvi_settings.h(198): warning C4005: '_UNICODE': macro redefinition
D:\dev\src\KVIrc\src\kvilib\config\kvi_settings.h(198): note: '_UNICODE' previously declared on the command line
[405/1166] Building CXX object src\kvilib\CMakeFiles\kvilib.dir\ext\KviNickColors.cpp.obj
D:\dev\src\KVIrc\src\kvilib\config\kvi_settings.h(197): warning C4005: 'UNICODE': macro redefinition
D:\dev\src\KVIrc\src\kvilib\config\kvi_settings.h(197): note: 'UNICODE' previously declared on the command line
D:\dev\src\KVIrc\src\kvilib\config\kvi_settings.h(198): warning C4005: '_UNICODE': macro redefinition
D:\dev\src\KVIrc\src\kvilib\config\kvi_settings.h(198): note: '_UNICODE' previously declared on the command line
[406/1166] Building CXX object src\kvilib\CMakeFiles\kvilib.dir\ext\KviProxy.cpp.obj
D:\dev\src\KVIrc\src\kvilib\config\kvi_settings.h(197): warning C4005: 'UNICODE': macro redefinition
D:\dev\src\KVIrc\src\kvilib\config\kvi_settings.h(197): note: 'UNICODE' previously declared on the command line
D:\dev\src\KVIrc\src\kvilib\config\kvi_settings.h(198): warning C4005: '_UNICODE': macro redefinition
D:\dev\src\KVIrc\src\kvilib\config\kvi_settings.h(198): note: '_UNICODE' previously declared on the command line
[407/1166] Building CXX object src\kvilib\CMakeFiles\kvilib.dir\ext\KviPixmapUtils.cpp.obj
D:\dev\src\KVIrc\src\kvilib\config\kvi_settings.h(197): warning C4005: 'UNICODE': macro redefinition
D:\dev\src\KVIrc\src\kvilib\config\kvi_settings.h(197): note: 'UNICODE' previously declared on the command line
D:\dev\src\KVIrc\src\kvilib\config\kvi_settings.h(198): warning C4005: '_UNICODE': macro redefinition
D:\dev\src\KVIrc\src\kvilib\config\kvi_settings.h(198): note: '_UNICODE' previously declared on the command line
[408/1166] Building CXX object src\kvilib\CMakeFiles\kvilib.dir\ext\KviProxyDataBase.cpp.obj
D:\dev\src\KVIrc\src\kvilib\config\kvi_settings.h(197): warning C4005: 'UNICODE': macro redefinition
D:\dev\src\KVIrc\src\kvilib\config\kvi_settings.h(197): note: 'UNICODE' previously declared on the command line
D:\dev\src\KVIrc\src\kvilib\config\kvi_settings.h(198): warning C4005: '_UNICODE': macro redefinition
D:\dev\src\KVIrc\src\kvilib\config\kvi_settings.h(198): note: '_UNICODE' previously declared on the command line
[409/1166] Building CXX object src\kvilib\CMakeFiles\kvilib.dir\ext\KviRegisteredChannel.cpp.obj
D:\dev\src\KVIrc\src\kvilib\config\kvi_settings.h(197): warning C4005: 'UNICODE': macro redefinition
D:\dev\src\KVIrc\src\kvilib\config\kvi_settings.h(197): note: 'UNICODE' previously declared on the command line
D:\dev\src\KVIrc\src\kvilib\config\kvi_settings.h(198): warning C4005: '_UNICODE': macro redefinition
D:\dev\src\KVIrc\src\kvilib\config\kvi_settings.h(198): note: '_UNICODE' previously declared on the command line
[410/1166] Building CXX object src\kvilib\CMakeFiles\kvilib.dir\ext\KviMediaManager.cpp.obj
D:\dev\src\KVIrc\src\kvilib\config\kvi_settings.h(197): warning C4005: 'UNICODE': macro redefinition
D:\dev\src\KVIrc\src\kvilib\config\kvi_settings.h(197): note: 'UNICODE' previously declared on the command line
D:\dev\src\KVIrc\src\kvilib\config\kvi_settings.h(198): warning C4005: '_UNICODE': macro redefinition
D:\dev\src\KVIrc\src\kvilib\config\kvi_settings.h(198): note: '_UNICODE' previously declared on the command line
[411/1166] Building CXX object src\kvilib\CMakeFiles\kvilib.dir\ext\KviRegExp.cpp.obj
D:\dev\src\KVIrc\src\kvilib\config\kvi_settings.h(197): warning C4005: 'UNICODE': macro redefinition
D:\dev\src\KVIrc\src\kvilib\config\kvi_settings.h(197): note: 'UNICODE' previously declared on the command line
D:\dev\src\KVIrc\src\kvilib\config\kvi_settings.h(198): warning C4005: '_UNICODE': macro redefinition
D:\dev\src\KVIrc\src\kvilib\config\kvi_settings.h(198): note: '_UNICODE' previously declared on the command line
[412/1166] Building CXX object src\kvilib\CMakeFiles\kvilib.dir\ext\KviRegisteredChannelDataBase.cpp.obj
D:\dev\src\KVIrc\src\kvilib\config\kvi_settings.h(197): warning C4005: 'UNICODE': macro redefinition
D:\dev\src\KVIrc\src\kvilib\config\kvi_settings.h(197): note: 'UNICODE' previously declared on the command line
D:\dev\src\KVIrc\src\kvilib\config\kvi_settings.h(198): warning C4005: '_UNICODE': macro redefinition
D:\dev\src\KVIrc\src\kvilib\config\kvi_settings.h(198): note: '_UNICODE' previously declared on the command line
[413/1166] Building CXX object src\kvilib\CMakeFiles\kvilib.dir\ext\KviAnimatedPixmap.cpp.obj
D:\dev\src\KVIrc\src\kvilib\config\kvi_settings.h(197): warning C4005: 'UNICODE': macro redefinition
D:\dev\src\KVIrc\src\kvilib\config\kvi_settings.h(197): note: 'UNICODE' previously declared on the command line
D:\dev\src\KVIrc\src\kvilib\config\kvi_settings.h(198): warning C4005: '_UNICODE': macro redefinition
D:\dev\src\KVIrc\src\kvilib\config\kvi_settings.h(198): note: '_UNICODE' previously declared on the command line
[414/1166] Building CXX object src\kvilib\CMakeFiles\kvilib.dir\ext\KviAnimatedPixmapCache.cpp.obj
D:\dev\src\KVIrc\src\kvilib\config\kvi_settings.h(197): warning C4005: 'UNICODE': macro redefinition
D:\dev\src\KVIrc\src\kvilib\config\kvi_settings.h(197): note: 'UNICODE' previously declared on the command line
D:\dev\src\KVIrc\src\kvilib\config\kvi_settings.h(198): warning C4005: '_UNICODE': macro redefinition
D:\dev\src\KVIrc\src\kvilib\config\kvi_settings.h(198): note: '_UNICODE' previously declared on the command line
ninja: build stopped: subcommand failed.

the unicode stuff is due to qt6 using -utf-8 in the command line which needed a change in the cmakelists due to: cl : Command line error D8016 : '/source-charset:utf-8' and '/utf-8' command-line options are incompatible

@ctrlaltca
Copy link
Contributor Author

The error is about KviHeapObject, that is a workaround for windows memory management, and definitely needs proper testing. Qt6 on windows currently is completely untested.
I'd stick with Qt5 for 5.2.x, then switch CI to Qt6 for mac and windows and see how it goes.
Thank you for the warning

@ctrlaltca
Copy link
Contributor Author

Released, closing.

@ctrlaltca ctrlaltca unpinned this issue Jan 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@Dessa @DarthGandalf @wodim @ctrlaltca