Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

KviShortcut: add new ctor to support QKeySequence::StandardKey with more than one QKeySequence #2689

Merged
merged 1 commit into from
Nov 19, 2024
Merged

KviShortcut: add new ctor to support QKeySequence::StandardKey with more than one QKeySequence #2689

merged 1 commit into from
Nov 19, 2024

Conversation

ctrlaltca
Copy link
Contributor

On Qt6 the cast from QKeySequence::StandardKey to QKeySequence will create the shortcut only on the first sequence.
From https://doc.qt.io/qt-6/qkeysequence.html#QKeySequence-1 :

The resulting object will be based on the first element in the list of key bindings for the key.

Fix #2685

@ctrlaltca ctrlaltca merged commit afed133 into kvirc:master Nov 19, 2024
5 checks passed
@ctrlaltca ctrlaltca deleted the fix_2685 branch November 19, 2024 21:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DarthGandalf DarthGandalf DarthGandalf left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

shift+delete no longer working to 'cut'?
2 participants
@ctrlaltca @DarthGandalf