Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Seems like published version is not the version built from git tag #256

Open
istarkov opened this issue Jul 7, 2024 · 1 comment
Open

Comments

@istarkov
Copy link
Contributor

istarkov commented Jul 7, 2024

Describe the Issue

json.d.ts in the published version

export declare const json: import("types").ResponseFormatter;

json.d.ts when I built it from 5.0.17 github tag

export declare const json: import("./types").ResponseFormatter;

See published version has import('types') (which is wrong) but it should be import('./types') as in built version.

Because of above the type of the import { json } from 'itty-router' is any
(no issues if right import is used (with relative import))

See
https://www.typescriptlang.org/play/?#code/JYWwDg9gTgLgBAbzgKwM4QHZwL5wGZQQhwDkwMMAngLSECuMAplCQNwBQ7amcqAhjGCo8wRqjgY6IAEbNWQA

image

It feels like some dirty version was published or some postprocessing ruined the right types

@kwhitley
Copy link
Owner

kwhitley commented Jul 7, 2024

Hmmmm good catch... def gives me some clue to how to fix, as this is almost certainly a post processing issue!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants