Skip to content

Commit

Permalink
Bump hardcoded image pull timeout to 5 minutes
Browse files Browse the repository at this point in the history
See: containers/image#2585

Signed-off-by: Krzysztof Wilczyński <[email protected]>
  • Loading branch information
kwilczynski committed Oct 21, 2024
1 parent a98ec33 commit c6e385c
Showing 1 changed file with 7 additions and 1 deletion.
8 changes: 7 additions & 1 deletion server/image_pull.go
Original file line number Diff line number Diff line change
Expand Up @@ -273,7 +273,13 @@ func (s *Server) pullImageCandidate(ctx context.Context, sourceCtx *imageTypes.S
func consumeImagePullProgress(ctx context.Context, cancel context.CancelFunc, progress <-chan imageTypes.ProgressProperties, remoteCandidateName storage.RegistryImageReference) {
// The progress interval is 1s, but we give it a bit more time just in case
// that the connection revives.
const timeout = 10 * time.Second
//
// FIXME: This is a temporary workaround for the lack of progress
// update events when composefs support is enabled. See then
// following containers/image issue:
// https://github.com/containers/image/issues/2585
const timeout = 5 * time.Minute
log.Warnf(ctx, "Time out for waiting on image pull progress overridden to: %v", timeout)
timer := time.AfterFunc(timeout, func() {
log.Warnf(ctx, "Timed out on waiting up to %s for image pull progress updates", timeout)
cancel()
Expand Down

0 comments on commit c6e385c

Please sign in to comment.