From c6e385c77963a093a7225d44a5eca721e123b0b9 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Krzysztof=20Wilczy=C5=84ski?= Date: Fri, 27 Sep 2024 21:02:07 +0900 Subject: [PATCH] Bump hardcoded image pull timeout to 5 minutes MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit See: https://github.com/containers/image/issues/2585 Signed-off-by: Krzysztof Wilczyński --- server/image_pull.go | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/server/image_pull.go b/server/image_pull.go index 90c81cd0de9..20c50efde7d 100644 --- a/server/image_pull.go +++ b/server/image_pull.go @@ -273,7 +273,13 @@ func (s *Server) pullImageCandidate(ctx context.Context, sourceCtx *imageTypes.S func consumeImagePullProgress(ctx context.Context, cancel context.CancelFunc, progress <-chan imageTypes.ProgressProperties, remoteCandidateName storage.RegistryImageReference) { // The progress interval is 1s, but we give it a bit more time just in case // that the connection revives. - const timeout = 10 * time.Second + // + // FIXME: This is a temporary workaround for the lack of progress + // update events when composefs support is enabled. See then + // following containers/image issue: + // https://github.com/containers/image/issues/2585 + const timeout = 5 * time.Minute + log.Warnf(ctx, "Time out for waiting on image pull progress overridden to: %v", timeout) timer := time.AfterFunc(timeout, func() { log.Warnf(ctx, "Timed out on waiting up to %s for image pull progress updates", timeout) cancel()