Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add additional drum kits #5

Open
kylestetz opened this issue Oct 2, 2018 · 3 comments
Open

Add additional drum kits #5

kylestetz opened this issue Oct 2, 2018 · 3 comments
Labels
enhancement New feature or request

Comments

@kylestetz
Copy link
Owner

The (drums) function can be extended to support a type argument, e.g. (drums 2), which controls what set of samples is played. A precedent around lazy loading each kit was already established in Drums.js; extending this should be easy and won't force users to download audio files unnecessarily.
@kylestetz kylestetz added the enhancement New feature or request label Oct 2, 2018
@ghost
Copy link

ghost commented Oct 3, 2018

Wow ;D this is cool

@andlehma andlehma mentioned this issue Oct 5, 2018
Open
@agbales
Copy link

agbales commented Oct 8, 2018

@kylestetz, are you thinking this will always draw samples from /public/audio/acoustic via loadDrumSounds and drumMap?

If I'm understanding that right, I'll take this one on!

@kylestetz
Copy link
Owner Author

Hey @agbales, someone already started taking this on in PR #10! Happy to have you pop in there and give some additional feedback if you're interested. I will probably be very slow at responding to/merging anything in this project 😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kylestetz @agbales