Skip to content

Commit

Permalink
fix: Custom resources details wrong opening (#3629)
Browse files Browse the repository at this point in the history
* Using Suspense to gently open the columns

* Removing unnecessary scroll under list item
  • Loading branch information
KonradPietocha authored Jan 27, 2025
1 parent b32cf54 commit 4168cf8
Show file tree
Hide file tree
Showing 2 changed files with 21 additions and 3 deletions.
6 changes: 6 additions & 0 deletions src/components/CustomResources/GroupingListPage.scss
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,12 @@
ui5-table-cell[slot='default-2'] {
width: 22vw;
}

ui5-panel {
&::part(content) {
overflow: unset;
}
}
}

@media (max-width: 850px) {
Expand Down
18 changes: 15 additions & 3 deletions src/resources/other/CustomResourcesByGroup.routes.js
Original file line number Diff line number Diff line change
Expand Up @@ -199,9 +199,21 @@ export const ColumnWrapper = ({ defaultColumn = 'list' }) => {
<FlexibleColumnLayout
style={{ height: '100%' }}
layout={layoutState?.layout || 'OneColumn'}
startColumn={<div className="column-content">{startColumnComponent}</div>}
midColumn={<div className="column-content">{midColumnComponent}</div>}
endColumn={<div className="column-content">{endColumnComponent}</div>}
startColumn={
<div className="column-content">
<Suspense fallback={<Spinner />}>{startColumnComponent}</Suspense>
</div>
}
midColumn={
<div className="column-content">
<Suspense fallback={<Spinner />}>{midColumnComponent}</Suspense>
</div>
}
endColumn={
<div className="column-content">
<Suspense fallback={<Spinner />}>{endColumnComponent}</Suspense>
</div>
}
/>
);
};
Expand Down

0 comments on commit 4168cf8

Please sign in to comment.