Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Replace kyma extensions with Modules #3573

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

feat: Replace kyma extensions with Modules #3573

wants to merge 2 commits into from
+57 −209

Conversation

akucharska
Copy link
Contributor

Description

Changes proposed in this pull request:

  • Remove Kyma extension
  • Show Modules in cluster and namespace navigation
  • ...

Related issue(s)

Definition of done

  • The PR's title starts with one of the following prefixes:
    • feat: A new feature
    • fix: A bug fix
    • docs: Documentation only changes
    • refactor: A code change that neither fixes a bug nor adds a feature
    • test: Adding tests
    • chore: Maintainance changes to the build process or auxiliary tools, libraries, workflows, etc.
  • Related issues are linked. To link internal trackers, use the issue IDs like backlog#4567
  • Explain clearly why you created the PR and what changes it introduces
  • All necessary steps are delivered, for example, tests, documentation, merging

@kyma-bot kyma-bot added cla: yes Indicates the PR's author has signed the CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jan 9, 2025
@akucharska akucharska linked an issue Jan 9, 2025 that may be closed by this pull request
Adjust Kyma Extensibility view to latest changes of the Modules Catalog #3548
Open
4 tasks
mrCherry97
mrCherry97 requested changes Jan 10, 2025
View reviewed changes
Copy link
Contributor

@mrCherry97 mrCherry97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When user will open a details for some of the module, then link is wrong, after closing the details, link is completely wrong and busola sometimes is making refresh to cluster level modules view

Screen.Recording.2025-01-10.at.10.55.46.mov

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrCherry97 mrCherry97 mrCherry97 requested changes

@dbadura dbadura Awaiting requested review from dbadura dbadura is a code owner

@chriskari chriskari Awaiting requested review from chriskari chriskari is a code owner

@OliwiaGowor OliwiaGowor Awaiting requested review from OliwiaGowor OliwiaGowor is a code owner

Requested changes must be addressed to merge this pull request.

Assignees

@mrCherry97 mrCherry97

Labels
cla: yes Indicates the PR's author has signed the CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Adjust Kyma Extensibility view to latest changes of the Modules Catalog
3 participants
@akucharska @mrCherry97 @kyma-bot