Skip to content

Commit

Permalink
enable oidc extension by default for newly provisioned clusters (#3467)
Browse files Browse the repository at this point in the history
  • Loading branch information
koala7659 authored Sep 3, 2024
1 parent 5e04f50 commit 8152ffd
Show file tree
Hide file tree
Showing 2 changed files with 21 additions and 0 deletions.
1 change: 1 addition & 0 deletions components/provisioner/internal/model/gardener_config.go
Original file line number Diff line number Diff line change
Expand Up @@ -211,6 +211,7 @@ func (c GardenerConfig) ToShootTemplate(namespace string, accountId string, subA
{Type: "shoot-dns-service", ProviderConfig: &apimachineryRuntime.RawExtension{Raw: jsonDNSConfig}},
{Type: "shoot-cert-service", ProviderConfig: &apimachineryRuntime.RawExtension{Raw: jsonCertConfig}},
{Type: ShootNetworkingFilterExtensionType, Disabled: util.OkOrDefault(c.ShootNetworkingFilterDisabled, util.PtrTo(ShootNetworkingFilterDisabledDefault))},
{Type: "shoot-oidc-service", Disabled: util.PtrTo(false)},
},
ControlPlane: controlPlane,
},
Expand Down
20 changes: 20 additions & 0 deletions components/provisioner/internal/model/gardener_config_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -243,6 +243,10 @@ func TestGardenerConfig_ToShootTemplate(t *testing.T) {
Type: ShootNetworkingFilterExtensionType,
Disabled: util.PtrTo(true),
},
{
Type: "shoot-oidc-service",
Disabled: util.PtrTo(false),
},
},
ControlPlane: &gardener_types.ControlPlane{
HighAvailability: &gardener_types.HighAvailability{
Expand Down Expand Up @@ -328,6 +332,10 @@ func TestGardenerConfig_ToShootTemplate(t *testing.T) {
Type: ShootNetworkingFilterExtensionType,
Disabled: util.PtrTo(true),
},
{
Type: "shoot-oidc-service",
Disabled: util.PtrTo(false),
},
},
ControlPlane: &gardener_types.ControlPlane{
HighAvailability: &gardener_types.HighAvailability{
Expand Down Expand Up @@ -413,6 +421,10 @@ func TestGardenerConfig_ToShootTemplate(t *testing.T) {
Type: ShootNetworkingFilterExtensionType,
Disabled: util.PtrTo(true),
},
{
Type: "shoot-oidc-service",
Disabled: util.PtrTo(false),
},
},
ControlPlane: &gardener_types.ControlPlane{
HighAvailability: &gardener_types.HighAvailability{
Expand Down Expand Up @@ -498,6 +510,10 @@ func TestGardenerConfig_ToShootTemplate(t *testing.T) {
Type: ShootNetworkingFilterExtensionType,
Disabled: util.PtrTo(true),
},
{
Type: "shoot-oidc-service",
Disabled: util.PtrTo(false),
},
},
ControlPlane: &gardener_types.ControlPlane{
HighAvailability: &gardener_types.HighAvailability{
Expand Down Expand Up @@ -585,6 +601,10 @@ func TestGardenerConfig_ToShootTemplate(t *testing.T) {
Type: ShootNetworkingFilterExtensionType,
Disabled: util.PtrTo(true),
},
{
Type: "shoot-oidc-service",
Disabled: util.PtrTo(false),
},
},
ControlPlane: &gardener_types.ControlPlane{
HighAvailability: &gardener_types.HighAvailability{
Expand Down

0 comments on commit 8152ffd

Please sign in to comment.