From a1413cf5a5ada21a768ccf02642d016aed7a482e Mon Sep 17 00:00:00 2001 From: Korbinian Stoemmer Date: Mon, 8 Apr 2024 14:33:09 +0200 Subject: [PATCH] apply code review comments --- .github/workflows/lint-go.yml | 4 ++-- internal/controller/operator/eventing/eventmesh_test.go | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/.github/workflows/lint-go.yml b/.github/workflows/lint-go.yml index e04885ae..0d703e5e 100644 --- a/.github/workflows/lint-go.yml +++ b/.github/workflows/lint-go.yml @@ -4,7 +4,7 @@ on: pull_request: branches: - "main" - - "release-*" + - "release-**" paths-ignore: - "docs/**" - "**.md" @@ -32,7 +32,7 @@ jobs: - name: Setup Go uses: actions/setup-go@v5 with: - go-version: 1.21 # This can be a specific version. E.g. 1.19 or 1.21.x + go-version: 1.22 # This can be a specific version. E.g. 1.19 or 1.21.x - name: Checkout code uses: actions/checkout@v4 diff --git a/internal/controller/operator/eventing/eventmesh_test.go b/internal/controller/operator/eventing/eventmesh_test.go index f793fc3c..cf0e07f2 100644 --- a/internal/controller/operator/eventing/eventmesh_test.go +++ b/internal/controller/operator/eventing/eventmesh_test.go @@ -537,7 +537,7 @@ func Test_stopEventMeshSubManager(t *testing.T) { // TestGetSecretForPublisher verifies the successful and failing retrieval // of secrets. func Test_GetSecretForPublisher(t *testing.T) { - eventingNS := "eventingNS" + eventingNS := "eventingns" secretFor := func(message, namespace []byte) *kcorev1.Secret { secret := &kcorev1.Secret{ ObjectMeta: kmetav1.ObjectMeta{ @@ -933,7 +933,7 @@ func Test_SyncPublisherProxySecret(t *testing.T) { } // when - _, err := r.SyncPublisherProxySecret(context.Background(), "eventingNS", testcase.givenSecret) + _, err := r.SyncPublisherProxySecret(context.Background(), "eventingns", testcase.givenSecret) // then if testcase.wantErr {